From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B78EFC4360C for ; Fri, 4 Oct 2019 19:33:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 811FD21D81 for ; Fri, 4 Oct 2019 19:33:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="BWP72EUX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 811FD21D81 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 20C828E0005; Fri, 4 Oct 2019 15:33:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 16EDB8E0003; Fri, 4 Oct 2019 15:33:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00E248E0005; Fri, 4 Oct 2019 15:33:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0179.hostedemail.com [216.40.44.179]) by kanga.kvack.org (Postfix) with ESMTP id C692B8E0003 for ; Fri, 4 Oct 2019 15:33:05 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 787EB181AC9AE for ; Fri, 4 Oct 2019 19:33:05 +0000 (UTC) X-FDA: 76007100330.10.smoke83_5518caf00b902 X-HE-Tag: smoke83_5518caf00b902 X-Filterd-Recvd-Size: 2789 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf36.hostedemail.com (Postfix) with ESMTP for ; Fri, 4 Oct 2019 19:33:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=LHh/YQwQTy7byEfLDg0tl2YRDGuuUomeM/luIJJrsME=; b=BWP72EUXNPAivlKYRsOMtPtaw Kp+yyT1wO0BN8iWpVPl+wKzLz6FEMavN+iPUFllU1t7UN7k/TOU5TjN50/T5X8Avm/n6ZkoC9GsH7 C7F0dR01CVPEPdLw6LgZuYdizR4Ul+FVlyZsh4h/NSlyWLYb51wNn1ziUt2QisHXe2+SOPRnWjxVf KIPKHdP/XPLB1+qhzkDpDsa9sMJ/Oad0sI4Slc6YCMXhsZFtLTbvyWcLsC9LJ9WnP30Dzix0gKsEY hrEEYiiu+NglwLFL5GWQ20TBs63WW4f6YrffxW1M4tFtHLs00SqLjbd7xne4o917PClzgzP/j/a/F zUEQoI0Sw==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.2 #3 (Red Hat Linux)) id 1iGTK2-00063Z-9N; Fri, 04 Oct 2019 19:33:02 +0000 Date: Fri, 4 Oct 2019 12:33:02 -0700 From: Matthew Wilcox To: Hillf Danton Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/15] mm: Add file_offset_of_ helpers Message-ID: <20191004193302.GL32665@bombadil.infradead.org> References: <20190925005214.27240-1-willy@infradead.org> <20191002130753.7680-1-hdanton@sina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191002130753.7680-1-hdanton@sina.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Your mail program is still broken. This shows up as a reply to the 0/15 email instead of as a reply to the 3/15 email. On Wed, Oct 02, 2019 at 09:07:53PM +0800, Hillf Danton wrote: > On Tue, 24 Sep 2019 17:52:02 -0700 From: Matthew Wilcox (Oracle) > > +/** > > + * file_offset_of_page - File offset of this page. > > + * @page: Page cache page. > > + * > > + * Context: Any context. > > + * Return: The offset of the first byte of this page. > > */ > > -static inline loff_t page_offset(struct page *page) > > +static inline loff_t file_offset_of_page(struct page *page) > > { > > return ((loff_t)page->index) << PAGE_SHIFT; > > } > > > > static inline loff_t page_file_offset(struct page *page) > > { > > return ((loff_t)page_index(page)) << PAGE_SHIFT; > > Would you like to specify the need to build a moon on the moon, > with another name though? I have no idea what you mean. Is this an idiom in your native language, perhaps?