From: Jerome Glisse <jglisse@redhat.com>
To: "Thomas Hellström (VMware)" <thomas_os@shipmail.org>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Kirill A. Shutemov" <kirill@shutemov.name>
Subject: Re: hmm pud-entry callback locking?
Date: Mon, 7 Oct 2019 10:19:19 -0400 [thread overview]
Message-ID: <20191007141919.GA3222@redhat.com> (raw)
In-Reply-To: <4d25d751-d03a-29c6-950b-cafe8d201784@shipmail.org>
On Sat, Oct 05, 2019 at 02:29:40PM +0200, Thomas Hellström (VMware) wrote:
> Hi, Jerome,
>
> I was asked by Kirill to try to unify the pagewalk pud_entry and pmd_entry
> callbacks. The only user of the pagewalk pud-entry is currently hmm.
>
> But the pagewalk code call pud_entry only for huge puds with the page-table
> lock held, whereas the hmm callback appears to assume it gets called
> unconditionally without the page-table lock held?
>
> Could you shed some light into this?
I think in my mind they were already unified :) I think easiest thing is
to remove the hmm pud walker, this is not a big deal this will break huge
pud for now, we can re-add this to hmm once you unified them.
Cheers,
Jérôme
prev parent reply other threads:[~2019-10-07 14:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-05 12:29 hmm pud-entry callback locking? Thomas Hellström (VMware)
2019-10-07 14:19 ` Jerome Glisse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191007141919.GA3222@redhat.com \
--to=jglisse@redhat.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=thomas_os@shipmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).