From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13C73C47404 for ; Mon, 7 Oct 2019 16:53:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D3B912070B for ; Mon, 7 Oct 2019 16:53:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D3B912070B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 718808E0005; Mon, 7 Oct 2019 12:53:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C9588E0003; Mon, 7 Oct 2019 12:53:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5DDFD8E0005; Mon, 7 Oct 2019 12:53:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0198.hostedemail.com [216.40.44.198]) by kanga.kvack.org (Postfix) with ESMTP id 3E4058E0003 for ; Mon, 7 Oct 2019 12:53:23 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 645265002 for ; Mon, 7 Oct 2019 16:53:22 +0000 (UTC) X-FDA: 76017584244.23.can41_1d62f35e07b05 X-HE-Tag: can41_1d62f35e07b05 X-Filterd-Recvd-Size: 2248 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Mon, 7 Oct 2019 16:53:21 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 471F668B20; Mon, 7 Oct 2019 18:53:15 +0200 (CEST) Date: Mon, 7 Oct 2019 18:53:15 +0200 From: Christoph Hellwig To: Mark Salyzyn Cc: Christoph Hellwig , Catalin Marinas , linux-kernel@vger.kernel.org, kernel-team@android.com, Andrew Morton , Yue Hu , Mike Rapoport , Will Deacon , Thomas Gleixner , Ryohei Suzuki , Doug Berger , Andrey Konovalov , Peng Fan , linux-mm@kvack.org, Robin Murphy Subject: Re: [PATCH] mm: export cma alloc and release Message-ID: <20191007165315.GA10317@lst.de> References: <20191002212257.196849-1-salyzyn@android.com> <20191003085528.GB21629@arrakis.emea.arm.com> <20191005083753.GA14691@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 07, 2019 at 09:50:31AM -0700, Mark Salyzyn wrote: > On 10/5/19 1:37 AM, Christoph Hellwig wrote: >> On Thu, Oct 03, 2019 at 09:55:28AM +0100, Catalin Marinas wrote: >>> Aren't drivers supposed to use the DMA API for such allocations rather >>> than invoking cma_*() directly? >> Yes, they are. > > We have an engineer assigned to rewriting the ion memory driver to use > dma_buf interfaces. Hopefully that effort will solve the problem of > requiring these interfaces to be exported so that that driver (and others) > can be modularized. > > Thanks for the reviews, drop this patch from the list and we will regroup, > and accept that standing code in the kernel can not be modularized for the > moment. How is that different from the "DMA-BUF Heaps (destaging ION)" series floating around?