From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C217AECE588 for ; Tue, 15 Oct 2019 11:04:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 75C8921927 for ; Tue, 15 Oct 2019 11:04:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 75C8921927 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D1F608E0007; Tue, 15 Oct 2019 07:04:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CCF318E0001; Tue, 15 Oct 2019 07:04:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BBEB68E0007; Tue, 15 Oct 2019 07:04:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0244.hostedemail.com [216.40.44.244]) by kanga.kvack.org (Postfix) with ESMTP id 99FF68E0001 for ; Tue, 15 Oct 2019 07:04:04 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 1ED2C180BAA5F for ; Tue, 15 Oct 2019 11:04:04 +0000 (UTC) X-FDA: 76045734408.03.dock77_4092a763e4347 X-HE-Tag: dock77_4092a763e4347 X-Filterd-Recvd-Size: 2327 Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Tue, 15 Oct 2019 11:04:03 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 364ECAC3E; Tue, 15 Oct 2019 11:04:02 +0000 (UTC) Date: Tue, 15 Oct 2019 13:04:01 +0200 From: Michal Hocko To: Konstantin Khlebnikov Cc: linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Vladimir Davydov , Johannes Weiner Subject: Re: [PATCH] mm/memcontrol: update lruvec counters in mem_cgroup_move_account Message-ID: <20191015110401.GZ317@dhcp22.suse.cz> References: <157112699975.7360.1062614888388489788.stgit@buzz> <20191015082048.GU317@dhcp22.suse.cz> <3b73e301-ea4a-5edb-9360-2ae9b4ad9f69@yandex-team.ru> <20191015103623.GX317@dhcp22.suse.cz> <31cab57d-6e79-33cb-1a58-99065c6e7b82@yandex-team.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <31cab57d-6e79-33cb-1a58-99065c6e7b82@yandex-team.ru> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 15-10-19 13:49:14, Konstantin Khlebnikov wrote: > On 15/10/2019 13.36, Michal Hocko wrote: > > On Tue 15-10-19 11:44:22, Konstantin Khlebnikov wrote: > > > On 15/10/2019 11.20, Michal Hocko wrote: > > > > On Tue 15-10-19 11:09:59, Konstantin Khlebnikov wrote: > > > > > Mapped, dirty and writeback pages are also counted in per-lruvec stats. > > > > > These counters needs update when page is moved between cgroups. > > > > > > > > Please describe the user visible effect. > > > > > > Surprisingly I don't see any users at this moment. > > > So, there is no effect in mainline kernel. > > > > Those counters are exported right? Or do we exclude them for v1? > > It seems per-lruvec statistics is not exposed anywhere. > And per-lruvec NR_FILE_MAPPED, NR_FILE_DIRTY, NR_WRITEBACK never had users. So why do we have it in the first place? I have to say that counters as we have them now are really clear as mud. This is really begging for a clean up. -- Michal Hocko SUSE Labs