From: Lyude Paul <lyude@redhat.com>
To: linux-mm@kvack.org, kasan-dev@googlegroups.com
Cc: Sean Paul <sean@poorly.run>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
linux-kernel@vger.kernel.org
Subject: [RFC] kasan: include the hashed pointer for an object's location
Date: Mon, 21 Oct 2019 22:18:11 -0400 [thread overview]
Message-ID: <20191022021810.3216-1-lyude@redhat.com> (raw)
The vast majority of the kernel that needs to print out pointers as a
way to keep track of a specific object in the kernel for debugging
purposes does so using hashed pointers, since these are "good enough".
Ironically, the one place we don't do this is within kasan. While
simply printing a hashed version of where an out of bounds memory access
occurred isn't too useful, printing out the hashed address of the object
in question usually is since that's the format most of the kernel is
likely to be using in debugging output.
Of course this isn't perfect though-having the object's originating
address doesn't help users at all that need to do things like printing
the address of a struct which is embedded within another struct, but
it's certainly better then not printing any hashed addresses. And users
which need to handle less trivial cases like that can simply fall back
to careful usage of %px.
Signed-off-by: Lyude Paul <lyude@redhat.com>
Cc: Sean Paul <sean@poorly.run>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Alexander Potapenko <glider@google.com>
Cc: Dmitry Vyukov <dvyukov@google.com>
Cc: kasan-dev@googlegroups.com
---
mm/kasan/report.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/mm/kasan/report.c b/mm/kasan/report.c
index 621782100eaa..0a5663fee1f7 100644
--- a/mm/kasan/report.c
+++ b/mm/kasan/report.c
@@ -128,8 +128,9 @@ static void describe_object_addr(struct kmem_cache *cache, void *object,
int rel_bytes;
pr_err("The buggy address belongs to the object at %px\n"
- " which belongs to the cache %s of size %d\n",
- object, cache->name, cache->object_size);
+ " (aka %p) which belongs to the cache\n"
+ " %s of size %d\n",
+ object, object, cache->name, cache->object_size);
if (!addr)
return;
--
2.21.0
next reply other threads:[~2019-10-22 2:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 2:18 Lyude Paul [this message]
2019-10-22 2:27 ` [RFC] kasan: include the hashed pointer for an object's location Dmitry Vyukov
2019-10-22 17:22 ` Lyude Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191022021810.3216-1-lyude@redhat.com \
--to=lyude@redhat.com \
--cc=aryabinin@virtuozzo.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox