From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F700CA9EB7 for ; Tue, 22 Oct 2019 08:21:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 59B2720684 for ; Tue, 22 Oct 2019 08:21:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59B2720684 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 100FD6B0006; Tue, 22 Oct 2019 04:21:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B1F66B0007; Tue, 22 Oct 2019 04:21:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F318F6B0008; Tue, 22 Oct 2019 04:21:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0009.hostedemail.com [216.40.44.9]) by kanga.kvack.org (Postfix) with ESMTP id D08C46B0006 for ; Tue, 22 Oct 2019 04:21:33 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 6F1A0180AD820 for ; Tue, 22 Oct 2019 08:21:33 +0000 (UTC) X-FDA: 76070726466.28.knife73_47c177fd6ac2c X-HE-Tag: knife73_47c177fd6ac2c X-Filterd-Recvd-Size: 2548 Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Tue, 22 Oct 2019 08:21:32 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id BBD6CB150; Tue, 22 Oct 2019 08:21:31 +0000 (UTC) Date: Tue, 22 Oct 2019 10:21:31 +0200 From: Michal Hocko To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alexander Duyck , Andrew Morton , Anshuman Khandual , Dan Williams , Mel Gorman , Mike Rapoport , Mike Rapoport , Oscar Salvador , Pavel Tatashin , Pavel Tatashin , Pingfan Liu , Qian Cai , Vlastimil Babka , Wei Yang Subject: Re: [PATCH v2 0/2] mm: Memory offlining + page isolation cleanups Message-ID: <20191022082131.GC9379@dhcp22.suse.cz> References: <20191021172353.3056-1-david@redhat.com> <25d3f071-3268-298b-e0c8-9c307d1015fe@redhat.com> <20191022080835.GZ9379@dhcp22.suse.cz> <1f56744d-2c22-6c12-8fe8-4a71e791c467@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1f56744d-2c22-6c12-8fe8-4a71e791c467@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 22-10-19 10:15:07, David Hildenbrand wrote: > On 22.10.19 10:08, Michal Hocko wrote: > > On Tue 22-10-19 08:52:28, David Hildenbrand wrote: > > > On 21.10.19 19:23, David Hildenbrand wrote: > > > > Two cleanups that popped up while working on (and discussing) virtio-mem: > > > > https://lkml.org/lkml/2019/9/19/463 > > > > > > > > Tested with DIMMs on x86. > > > > > > > > As discussed with michal in v1, I'll soon look into removing the use > > > > of PG_reserved during memory onlining completely - most probably > > > > disallowing to offline memory blocks with holes, cleaning up the > > > > onlining+offlining code. > > > > > > BTW, I remember that ZONE_DEVICE pages are still required to be set > > > PG_reserved. That has to be sorted out first. > > > > Do they? > > Yes, especially KVM code :/ Details please? -- Michal Hocko SUSE Labs