From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 224AACA9EA0 for ; Tue, 22 Oct 2019 10:33:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F01BE20B7C for ; Tue, 22 Oct 2019 10:33:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F01BE20B7C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 88F416B0007; Tue, 22 Oct 2019 06:33:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 83F536B0008; Tue, 22 Oct 2019 06:33:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 754E36B000A; Tue, 22 Oct 2019 06:33:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0102.hostedemail.com [216.40.44.102]) by kanga.kvack.org (Postfix) with ESMTP id 5306E6B0007 for ; Tue, 22 Oct 2019 06:33:30 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id DEA04180AD815 for ; Tue, 22 Oct 2019 10:33:29 +0000 (UTC) X-FDA: 76071058938.09.pig24_3b98d233e3821 X-HE-Tag: pig24_3b98d233e3821 X-Filterd-Recvd-Size: 2102 Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Tue, 22 Oct 2019 10:33:29 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 76520B34A; Tue, 22 Oct 2019 10:33:28 +0000 (UTC) Date: Tue, 22 Oct 2019 12:33:25 +0200 From: Oscar Salvador To: Michal Hocko Cc: n-horiguchi@ah.jp.nec.com, mike.kravetz@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 10/16] mm,hwpoison: Rework soft offline for free pages Message-ID: <20191022103319.GA21736@linux> References: <20191017142123.24245-11-osalvador@suse.de> <20191018120615.GM5017@dhcp22.suse.cz> <20191021125842.GA11330@linux> <20191021154158.GV9379@dhcp22.suse.cz> <20191022074615.GA19060@linux> <20191022082611.GD9379@dhcp22.suse.cz> <20191022083505.GA19708@linux> <20191022092256.GH9379@dhcp22.suse.cz> <20191022095852.GB20429@linux> <20191022102457.GJ9379@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191022102457.GJ9379@dhcp22.suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 22, 2019 at 12:24:57PM +0200, Michal Hocko wrote: > Yes, that makes a perfect sense. What I am saying that the migration > (aka trying to recover) is the main and only difference. The soft > offline should poison page tables when not able to migrate as well > IIUC. Yeah, I see your point. I do not really why soft-offline strived so much to left the page untouched unless it was able to content the problem. Note that if we start now to poison pages even if we could not content them (in soft-offline mode), that is a big and visible user change. Not saying it is wrong, but something to consider. Anyway, I would like to put that aside as a follow-up rework after this one, as this one already changes quite some things. -- Oscar Salvador SUSE L3