From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08E48CA9EC9 for ; Fri, 1 Nov 2019 07:58:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CDF11208CB for ; Fri, 1 Nov 2019 07:58:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CDF11208CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 54C616B0270; Fri, 1 Nov 2019 03:58:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D5146B0272; Fri, 1 Nov 2019 03:58:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39B6E6B0273; Fri, 1 Nov 2019 03:58:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0241.hostedemail.com [216.40.44.241]) by kanga.kvack.org (Postfix) with ESMTP id 0AD786B0270 for ; Fri, 1 Nov 2019 03:58:45 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id AA9B14DD0 for ; Fri, 1 Nov 2019 07:58:44 +0000 (UTC) X-FDA: 76106956968.24.van99_12146f74e111d X-HE-Tag: van99_12146f74e111d X-Filterd-Recvd-Size: 3977 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by imf24.hostedemail.com (Postfix) with ESMTP for ; Fri, 1 Nov 2019 07:58:44 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Nov 2019 00:58:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,254,1569308400"; d="scan'208";a="225962514" Received: from yhuang-dev.sh.intel.com ([10.239.159.29]) by fmsmga004.fm.intel.com with ESMTP; 01 Nov 2019 00:58:41 -0700 From: "Huang, Ying" To: Peter Zijlstra Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Huang Ying , Andrew Morton , Michal Hocko , Rik van Riel , Mel Gorman , Ingo Molnar , Dave Hansen , Dan Williams , Fengguang Wu Subject: [RFC 09/10] autonuma, memory tiering: Double hot threshold for write hint page fault Date: Fri, 1 Nov 2019 15:57:26 +0800 Message-Id: <20191101075727.26683-10-ying.huang@intel.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191101075727.26683-1-ying.huang@intel.com> References: <20191101075727.26683-1-ying.huang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Huang Ying The write performance of PMEM is much worse than its read performance. So even if a write-mostly pages is colder than a read-mostly pages, it is usually better to put the write-mostly pages in DRAM and read-mostly pages in PMEM. To give write-mostly pages more opportunity to be promoted to DRAM, in this patch, the hot threshold for write hint page fault is doubled (easier to be promoted). Signed-off-by: "Huang, Ying" Cc: Andrew Morton Cc: Michal Hocko Cc: Rik van Riel Cc: Mel Gorman Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Dave Hansen Cc: Dan Williams Cc: Fengguang Wu Cc: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org --- include/linux/sched/numa_balancing.h | 1 + kernel/sched/fair.c | 2 ++ mm/memory.c | 3 +++ 3 files changed, 6 insertions(+) diff --git a/include/linux/sched/numa_balancing.h b/include/linux/sched/n= uma_balancing.h index e1c2728d5bb2..65dc8c6e8377 100644 --- a/include/linux/sched/numa_balancing.h +++ b/include/linux/sched/numa_balancing.h @@ -15,6 +15,7 @@ #define TNF_FAULT_LOCAL 0x08 #define TNF_MIGRATE_FAIL 0x10 #define TNF_YOUNG 0x20 +#define TNF_WRITE 0x40 =20 #ifdef CONFIG_NUMA_BALANCING extern void task_numa_fault(int last_node, int node, int pages, int flag= s); diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index d6cf5832556e..0a83e9cf6685 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -1513,6 +1513,8 @@ bool should_numa_migrate_memory(struct task_struct = *p, struct page * page, =20 threshold =3D msecs_to_jiffies( sysctl_numa_balancing_hot_threshold); + if (flags & TNF_WRITE) + threshold *=3D 2; latency =3D numa_hint_fault_latency(p, addr); if (latency > threshold) return false; diff --git a/mm/memory.c b/mm/memory.c index 80902ff7f5de..fed6c943ba60 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -3729,6 +3729,9 @@ static vm_fault_t do_numa_page(struct vm_fault *vmf= ) if (pte_young(old_pte)) flags |=3D TNF_YOUNG; =20 + if (vmf->flags & FAULT_FLAG_WRITE) + flags |=3D TNF_WRITE; + page =3D vm_normal_page(vma, vmf->address, pte); if (!page) goto unmap_out; --=20 2.23.0