From: rppt@kernel.org
To: Richard Weinberger <richard@nod.at>
Cc: linux-mm <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
anton ivanov <anton.ivanov@cambridgegreys.com>,
Arnd Bergmann <arnd@arndb.de>, davem <davem@davemloft.net>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Greentime Hu <green.hu@gmail.com>,
Greg Ungerer <gerg@linux-m68k.org>, Helge Deller <deller@gmx.de>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
Jeff Dike <jdike@addtoit.com>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
torvalds <torvalds@linux-foundation.org>,
Mark Salter <msalter@redhat.com>,
Matt Turner <mattst88@gmail.com>, Michal Simek <monstr@monstr.eu>,
Peter Rosin <peda@axentia.se>,
Rolf Eike Beer <eike-kernel@sf-tec.de>,
Russell King <linux@armlinux.org.uk>,
Sam Creasey <sammy@sammy.net>, Vincent Chen <deanbo422@gmail.com>,
Vineet Gupta <Vineet.Gupta1@synopsys.com>,
linux-alpha <linux-alpha@vger.kernel.org>,
linux-arch <linux-arch@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-c6x-dev@kvack.org
Subject: Re: [PATCH v2 12/13] um: add support for folded p4d page tables
Date: Fri, 01 Nov 2019 11:14:28 +0100 [thread overview]
Message-ID: <20191101101432.7998A2086D@mail.kernel.org> (raw)
In-Reply-To: <1435962204.69872.1572600009245.JavaMail.zimbra@nod.at>
<linux-c6x-dev@linux-c6x.org>,linux-kernel <linux-kernel@vger.kernel.org>,linux-m68k <linux-m68k@lists.linux-m68k.org>,linux-parisc <linux-parisc@vger.kernel.org>,linux-um <linux-um@lists.infradead.org>,sparclinux <sparclinux@vger.kernel.org>,Mike Rapoport <rppt@linux.ibm.com>
From: Mike Rapoport <rppt@kernel.org>
Message-ID: <E5D8BD4D-5286-427C-A347-D73AC26EC256@kernel.org>
On November 1, 2019 10:20:09 AM GMT+01:00, Richard Weinberger <richard@nod.at> wrote:
>----- Ursprüngliche Mail -----
>> Von: "Mike Rapoport" <rppt@kernel.org>
>
>[...]
>
>> #define pte_page(x) pfn_to_page(pte_pfn(x))
>> diff --git a/arch/um/kernel/mem.c b/arch/um/kernel/mem.c
>> index 417ff64..6fd17bc 100644
>> --- a/arch/um/kernel/mem.c
>> +++ b/arch/um/kernel/mem.c
>> @@ -92,10 +92,26 @@ static void __init one_md_table_init(pud_t *pud)
>> #endif
>> }
>>
>> +static void __init one_pud_table_init(p4d_t *p4d)
>> +{
>> +#if CONFIG_PGTABLE_LEVELS > 3
>
>Isn't this dead code?
>
>For uml we have:
>config PGTABLE_LEVELS
> int
> default 3 if 3_LEVEL_PGTABLES
> default 2
It's kinda a provision for 4 levels support in UML :)
I can drop this in the next respin, no problem.
>Thanks,
>//richard
--
Sincerely yours,
Mike
next prev parent reply other threads:[~2019-11-01 10:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 8:39 [PATCH v2 00/13] mm: remove __ARCH_HAS_4LEVEL_HACK Mike Rapoport
2019-11-01 8:39 ` [PATCH v2 01/13] alpha: use pgtable-nop4d instead of 4level-fixup Mike Rapoport
2019-11-01 9:11 ` Kirill A. Shutemov
2019-11-01 21:59 ` Mike Rapoport
2019-11-01 8:39 ` [PATCH v2 02/13] arm: nommu: use pgtable-nopud " Mike Rapoport
2019-11-01 8:39 ` [PATCH v2 03/13] c6x: " Mike Rapoport
2019-11-01 8:39 ` [PATCH v2 04/13] m68k: nommu: " Mike Rapoport
2019-11-01 8:39 ` [PATCH v2 05/13] m68k: mm: use pgtable-nopXd " Mike Rapoport
2019-11-01 8:39 ` [PATCH v2 06/13] microblaze: use pgtable-nopmd " Mike Rapoport
2019-11-01 8:39 ` [PATCH v2 07/13] nds32: " Mike Rapoport
2019-11-01 8:39 ` [PATCH v2 08/13] parisc: use pgtable-nopXd " Mike Rapoport
2019-11-01 8:39 ` [PATCH v2 09/13] parisc/hugetlb: " Mike Rapoport
2019-11-01 8:39 ` [PATCH v2 10/13] sparc32: use pgtable-nopud " Mike Rapoport
2019-11-01 8:39 ` [PATCH v2 11/13] um: remove unused pxx_offset_proc() and addr_pte() functions Mike Rapoport
2019-11-01 9:12 ` Richard Weinberger
2019-11-01 8:39 ` [PATCH v2 12/13] um: add support for folded p4d page tables Mike Rapoport
2019-11-01 9:20 ` Richard Weinberger
2019-11-01 10:14 ` rppt [this message]
2019-11-01 8:39 ` [PATCH v2 13/13] mm: remove __ARCH_HAS_4LEVEL_HACK and include/asm-generic/4level-fixup.h Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191101101432.7998A2086D@mail.kernel.org \
--to=rppt@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=akpm@linux-foundation.org \
--cc=anton.ivanov@cambridgegreys.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=deanbo422@gmail.com \
--cc=deller@gmx.de \
--cc=eike-kernel@sf-tec.de \
--cc=geert@linux-m68k.org \
--cc=gerg@linux-m68k.org \
--cc=green.hu@gmail.com \
--cc=jdike@addtoit.com \
--cc=kirill@shutemov.name \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-c6x-dev@kvack.org \
--cc=linux-mm@kvack.org \
--cc=linux@armlinux.org.uk \
--cc=mattst88@gmail.com \
--cc=monstr@monstr.eu \
--cc=msalter@redhat.com \
--cc=peda@axentia.se \
--cc=richard@nod.at \
--cc=sammy@sammy.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).