From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, INCLUDES_PATCH,MAILING_LIST_MULTI,MIME_QP_LONG_LINE,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 439D7CA9ECF for ; Fri, 1 Nov 2019 10:14:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E07C021855 for ; Fri, 1 Nov 2019 10:14:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="slfnJUOu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E07C021855 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5F2816B0005; Fri, 1 Nov 2019 06:14:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A1DE6B0006; Fri, 1 Nov 2019 06:14:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B75E6B0007; Fri, 1 Nov 2019 06:14:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0073.hostedemail.com [216.40.44.73]) by kanga.kvack.org (Postfix) with ESMTP id 29AA16B0005 for ; Fri, 1 Nov 2019 06:14:35 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id B6DEA4DAD for ; Fri, 1 Nov 2019 10:14:34 +0000 (UTC) X-FDA: 76107299268.26.dress84_27e8881c5e604 X-HE-Tag: dress84_27e8881c5e604 X-Filterd-Recvd-Size: 3719 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf07.hostedemail.com (Postfix) with ESMTP for ; Fri, 1 Nov 2019 10:14:34 +0000 (UTC) Received: from [172.20.33.98] (unknown [91.217.168.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7998A2086D; Fri, 1 Nov 2019 10:14:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572603273; bh=yZctnhE8ydugwCZWCgTxz8UucAyxJoh5W9y/O7iyOQI=; h=Date:In-Reply-To:References:Subject:To:CC:From:From; b=slfnJUOu2R2Lq4bGn6qHIg4mJZZaAFU2VJUMCjoUXPPOJfiDzb//RzSVYyEL2uHjj ep3oLIUO4xnaRN/mSzvsENH6nNaEDBZefMsHcOqj4xfzKSd10py5bZROhZBLLGfuaC JHM+4ZGhc7H/dGVowx+QbrvRxbthnHAE+gl6UkqI= Date: Fri, 01 Nov 2019 11:14:28 +0100 User-Agent: K-9 Mail for Android In-Reply-To: <1435962204.69872.1572600009245.JavaMail.zimbra@nod.at> References: <1572597584-6390-1-git-send-email-rppt@kernel.org> <1572597584-6390-13-git-send-email-rppt@kernel.org> <1435962204.69872.1572600009245.JavaMail.zimbra@nod.at> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v2 12/13] um: add support for folded p4d page tables To: Richard Weinberger CC: linux-mm , Andrew Morton , anton ivanov , Arnd Bergmann , davem , Geert Uytterhoeven , Greentime Hu , Greg Ungerer , Helge Deller , "James E.J. Bottomley" , Jeff Dike , "Kirill A. Shutemov" , torvalds , Mark Salter , Matt Turner , Michal Simek , Peter Rosin , Rolf Eike Beer , Russell King , Sam Creasey , Vincent Chen , Vineet Gupta , linux-alpha , linux-arch , linux-arm-kernel , linux-c6x-dev@kvack.org Message-Id: <20191101101432.7998A2086D@mail.kernel.org> From: rppt@kernel.org X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: ,linux-kernel ,linux-m68k ,linux-parisc ,linux-um ,sparclinux ,Mike Rapoport From: Mike Rapoport Message-ID: On November 1, 2019 10:20:09 AM GMT+01:00, Richard Weinberger wrote: >----- Urspr=C3=BCngliche Mail ----- >> Von: "Mike Rapoport" > >[=2E=2E=2E] > >> #define pte_page(x) pfn_to_page(pte_pfn(x)) >> diff --git a/arch/um/kernel/mem=2Ec b/arch/um/kernel/mem=2Ec >> index 417ff64=2E=2E6fd17bc 100644 >> --- a/arch/um/kernel/mem=2Ec >> +++ b/arch/um/kernel/mem=2Ec >> @@ -92,10 +92,26 @@ static void __init one_md_table_init(pud_t *pud) >> #endif >> } >>=20 >> +static void __init one_pud_table_init(p4d_t *p4d) >> +{ >> +#if CONFIG_PGTABLE_LEVELS > 3 > >Isn't this dead code? > >For uml we have: >config PGTABLE_LEVELS > int > default 3 if 3_LEVEL_PGTABLES > default 2 It's kinda a provision for 4 levels support in UML :) I can drop this in the next respin, no problem=2E >Thanks, >//richard --=20 Sincerely yours, Mike