From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE994C43215 for ; Fri, 15 Nov 2019 19:58:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 57A0D2073A for ; Fri, 15 Nov 2019 19:58:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="tH4LTUuA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 57A0D2073A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C75DD6B0005; Fri, 15 Nov 2019 14:58:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C26AB6B0006; Fri, 15 Nov 2019 14:58:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B153C6B0007; Fri, 15 Nov 2019 14:58:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0245.hostedemail.com [216.40.44.245]) by kanga.kvack.org (Postfix) with ESMTP id A74316B0005 for ; Fri, 15 Nov 2019 14:58:03 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 80905824D19F for ; Fri, 15 Nov 2019 19:58:03 +0000 (UTC) X-FDA: 76159572846.03.hot28_80835cb0a1a42 X-HE-Tag: hot28_80835cb0a1a42 X-Filterd-Recvd-Size: 2559 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Fri, 15 Nov 2019 19:58:02 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1847720733; Fri, 15 Nov 2019 19:58:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573847881; bh=9eEUACUiUScydrh4MXxVRPBLnMoSekdOCE+FsJAkc3E=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tH4LTUuA0frt+nTxwAqJnW7b7yALaBBF/joGatE/G6dCMM7ljKX4XluD4UjyZhNaz HVoVEu40i27bJ3534wFVLL7qHyYVMF2kFXZSAPA5EvudNcvw08l555KbwKICfXWP8V JroVYAegFpyC3WQq23xul25MMLVR3/ZZHHs9YRhU= Date: Fri, 15 Nov 2019 11:58:00 -0800 From: Andrew Morton To: Thomas =?ISO-8859-1?Q?Hellstr=F6m?= (VMware) Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Thomas Hellstrom , Arnd Bergmann , "Kirill A. Shutemov" , Matthew Wilcox Subject: Re: [PATCH 2/2] mm: Fix a huge pud insertion race during faulting Message-Id: <20191115115800.45c053abcdb550d70b9baec9@linux-foundation.org> In-Reply-To: <20191115115808.21181-2-thomas_os@shipmail.org> References: <20191115115808.21181-1-thomas_os@shipmail.org> <20191115115808.21181-2-thomas_os@shipmail.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 15 Nov 2019 12:58:08 +0100 Thomas Hellstr=F6m (VMware) wrote: > A huge pud page can theoretically be faulted in racing with pmd_alloc() > in __handle_mm_fault(). That will lead to pmd_alloc() returning an > invalid pmd pointer. Fix this by adding a pud_trans_unstable() function > similar to pmd_trans_unstable() and check whether the pud is really stable > before using the pmd pointer. >=20 > Race: > Thread 1: Thread 2: Comment > create_huge_pud() Fallback - not taken. > create_huge_pud() Taken. > pmd_alloc() Returns an invalid pointe= r. What are the user-visible runtime effects of this change? Is a -stable backport warranted?