From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C1C5C432C0 for ; Thu, 21 Nov 2019 15:20:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2763A20674 for ; Thu, 21 Nov 2019 15:20:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2763A20674 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.page Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CD5D06B0332; Thu, 21 Nov 2019 10:20:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C90296B0333; Thu, 21 Nov 2019 10:20:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B9C9D6B0334; Thu, 21 Nov 2019 10:20:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0088.hostedemail.com [216.40.44.88]) by kanga.kvack.org (Postfix) with ESMTP id 9FFF06B0332 for ; Thu, 21 Nov 2019 10:20:35 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 636864DD9 for ; Thu, 21 Nov 2019 15:20:35 +0000 (UTC) X-FDA: 76180646430.21.land21_5c6180f790812 X-HE-Tag: land21_5c6180f790812 X-Filterd-Recvd-Size: 2660 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Thu, 21 Nov 2019 15:20:34 +0000 (UTC) X-Originating-IP: 153.3.140.100 Received: from localhost.localdomain.localdomain (unknown [153.3.140.100]) (Authenticated sender: fly@kernel.page) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 02CAE1C001E; Thu, 21 Nov 2019 15:20:26 +0000 (UTC) From: Pengfei Li To: akpm@linux-foundation.org Cc: mgorman@techsingularity.net, mhocko@kernel.org, vbabka@suse.cz, cl@linux.com, iamjoonsoo.kim@lge.com, guro@fb.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Pengfei Li Subject: [RFC v1 06/19] mm, vmscan: use for_each_node in do_try_to_free_pages() Date: Thu, 21 Nov 2019 23:17:58 +0800 Message-Id: <20191121151811.49742-7-fly@kernel.page> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191121151811.49742-1-fly@kernel.page> References: <20191121151811.49742-1-fly@kernel.page> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: In do_try_to_free_pages(), we want to traverse node instead of zone, so use for_each_node instead of for_each_zone. Signed-off-by: Pengfei Li --- mm/vmscan.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index a3ad433c8ff4..159a2aaa8db1 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -3033,9 +3033,9 @@ static unsigned long do_try_to_free_pages(struct no= delist *nodelist, struct scan_control *sc) { int initial_priority =3D sc->priority; - pg_data_t *last_pgdat; + pg_data_t *pgdat; struct nlist_traverser t; - struct zone *zone; + int node; retry: delayacct_freepages_start(); =20 @@ -3062,20 +3062,17 @@ static unsigned long do_try_to_free_pages(struct = nodelist *nodelist, sc->may_writepage =3D 1; } while (--sc->priority >=3D 0); =20 - last_pgdat =3D NULL; - for_each_zone_nlist_nodemask(zone, &t, nodelist, sc->reclaim_idx, - sc->nodemask) { - if (zone->zone_pgdat =3D=3D last_pgdat) - continue; - last_pgdat =3D zone->zone_pgdat; + for_each_node_nlist_nodemask(node, &t, nodelist, + sc->reclaim_idx, sc->nodemask) { + pgdat =3D NODE_DATA(node); =20 - snapshot_refaults(sc->target_mem_cgroup, zone->zone_pgdat); + snapshot_refaults(sc->target_mem_cgroup, pgdat); =20 if (cgroup_reclaim(sc)) { struct lruvec *lruvec; =20 lruvec =3D mem_cgroup_lruvec(sc->target_mem_cgroup, - zone->zone_pgdat); + pgdat); clear_bit(LRUVEC_CONGESTED, &lruvec->flags); } } --=20 2.23.0