From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E366C432C0 for ; Mon, 25 Nov 2019 14:46:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 313ED2068F for ; Mon, 25 Nov 2019 14:46:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 313ED2068F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.page Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D9AF46B05D8; Mon, 25 Nov 2019 09:46:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D4A9F6B05D9; Mon, 25 Nov 2019 09:46:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C61086B05DA; Mon, 25 Nov 2019 09:46:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0233.hostedemail.com [216.40.44.233]) by kanga.kvack.org (Postfix) with ESMTP id AE7D26B05D8 for ; Mon, 25 Nov 2019 09:46:38 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 83F56180AD81C for ; Mon, 25 Nov 2019 14:46:38 +0000 (UTC) X-FDA: 76195076076.08.pot60_1cc250f11a206 X-HE-Tag: pot60_1cc250f11a206 X-Filterd-Recvd-Size: 2714 Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [217.70.178.230]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Mon, 25 Nov 2019 14:46:37 +0000 (UTC) Received: from localhost (unknown [153.3.124.115]) (Authenticated sender: fly@kernel.page) by relay10.mail.gandi.net (Postfix) with ESMTPSA id DB06A24000E; Mon, 25 Nov 2019 14:46:22 +0000 (UTC) Date: Mon, 25 Nov 2019 22:46:03 +0800 From: Pengfei Li To: Michal Hocko Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, vbabka@suse.cz, cl@linux.com, iamjoonsoo.kim@lge.com, guro@fb.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, fly@kernel.page Subject: Re: [RFC v1 00/19] Modify zonelist to nodelist v1 Message-ID: <20191125224603.688cb69c.fly@kernel.page> In-Reply-To: <20191125084058.GD31714@dhcp22.suse.cz> References: <20191121151811.49742-1-fly@kernel.page> <20191121180401.GL23213@dhcp22.suse.cz> <20191122230543.2f106c80.fly@kernel.page> <20191125084058.GD31714@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 25 Nov 2019 09:40:58 +0100 Michal Hocko wrote: > On Fri 22-11-19 23:05:43, Pengfei Li wrote: > > On Thu, 21 Nov 2019 19:04:01 +0100 > > Michal Hocko wrote: > > > > > On Thu 21-11-19 23:17:52, Pengfei Li wrote: > > > [...] > > > > Since I don't currently have multiple node NUMA systems, I > > > > would be grateful if anyone would like to test this series of > > > > patches. > > > > > > I didn't really get to think about the actual patchset. From a > > > very quick glance I am wondering whether we need to optimize as > > > there are usually only small amount of numa nodes. But I am quite > > > busy so I cannot really do any claims. > > > > Thanks for your comments. > > > > I think it's time to modify the zonelist to nodelist because the > > zonelist is always in node order and the page reclamation is based > > on node. > > > > I will do more performance testing to show that multi-node systems > > will benefit from this series of patches. > > Sensible performance numbers on multiple workloads (ideally some real > world ones rather than artificial microbenchmarks) is essential for a > performance optimization that is this large. Thank you for your suggestion. But this is probably a bit difficult because I don't have a NUMA server to do real-world workload testing. I will do as many performance benchmarks as possible, just like Mel Gorman's "Move LRU page reclaim from zones to nodes v9" (https://lwn.net/Articles/694121/). -- Pengfei