* [RFC PATCH v1 2/4] mm: also set VMA in khugepaged range invalidation
@ 2019-12-11 9:29 Mircea CIRJALIU - MELIU
2019-12-11 15:44 ` Kirill A. Shutemov
0 siblings, 1 reply; 3+ messages in thread
From: Mircea CIRJALIU - MELIU @ 2019-12-11 9:29 UTC (permalink / raw)
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jerome Glisse,
Paolo Bonzini, aarcange@redhat.com
MMU notifier client may need the VMA for extra info.
This change is needed by the remote mapping feature that inspects anon VMAs
with huge mappings.
Signed-off-by: Mircea Cirjaliu <mcirjaliu@bitdefender.com>
---
mm/khugepaged.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/khugepaged.c b/mm/khugepaged.c
index b679908..11c65f3 100644
--- a/mm/khugepaged.c
+++ b/mm/khugepaged.c
@@ -1028,7 +1028,7 @@ static void collapse_huge_page(struct mm_struct *mm,
anon_vma_lock_write(vma->anon_vma);
- mmu_notifier_range_init(&range, MMU_NOTIFY_CLEAR, 0, NULL, mm,
+ mmu_notifier_range_init(&range, MMU_NOTIFY_CLEAR, 0, vma, mm,
address, address + HPAGE_PMD_SIZE);
mmu_notifier_invalidate_range_start(&range);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC PATCH v1 2/4] mm: also set VMA in khugepaged range invalidation
2019-12-11 9:29 [RFC PATCH v1 2/4] mm: also set VMA in khugepaged range invalidation Mircea CIRJALIU - MELIU
@ 2019-12-11 15:44 ` Kirill A. Shutemov
2019-12-11 16:16 ` Mircea CIRJALIU - MELIU
0 siblings, 1 reply; 3+ messages in thread
From: Kirill A. Shutemov @ 2019-12-11 15:44 UTC (permalink / raw)
To: Mircea CIRJALIU - MELIU
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jerome Glisse,
Paolo Bonzini, aarcange@redhat.com
On Wed, Dec 11, 2019 at 09:29:21AM +0000, Mircea CIRJALIU - MELIU wrote:
> MMU notifier client may need the VMA for extra info.
> This change is needed by the remote mapping feature that inspects anon VMAs
> with huge mappings.
The change itself is okay, but commit message should be better.
Do we have any user of mmu notifiers in current kernel that affected by
the missing vma here?
And subject starting with 'also' looks wrong to me.
--
Kirill A. Shutemov
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [RFC PATCH v1 2/4] mm: also set VMA in khugepaged range invalidation
2019-12-11 15:44 ` Kirill A. Shutemov
@ 2019-12-11 16:16 ` Mircea CIRJALIU - MELIU
0 siblings, 0 replies; 3+ messages in thread
From: Mircea CIRJALIU - MELIU @ 2019-12-11 16:16 UTC (permalink / raw)
To: Kirill A. Shutemov
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jerome Glisse,
Paolo Bonzini, aarcange@redhat.com
> On Wed, Dec 11, 2019 at 09:29:21AM +0000, Mircea CIRJALIU - MELIU wrote:
> > MMU notifier client may need the VMA for extra info.
> > This change is needed by the remote mapping feature that inspects anon
> > VMAs with huge mappings.
>
> The change itself is okay, but commit message should be better.
>
> Do we have any user of mmu notifiers in current kernel that affected by the
> missing vma here?
No. This patch is a small part of a series of commits for the remote mapping feature.
The kernel can do well without it.
>
> And subject starting with 'also' looks wrong to me.
>
> --
> Kirill A. Shutemov
Mircea
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-11 16:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-11 9:29 [RFC PATCH v1 2/4] mm: also set VMA in khugepaged range invalidation Mircea CIRJALIU - MELIU
2019-12-11 15:44 ` Kirill A. Shutemov
2019-12-11 16:16 ` Mircea CIRJALIU - MELIU
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox