Re: [PATCH 1/5] fs: add read support for RWF_UNCACHED

Matthew Wilcox
2019-12-12T21:21:54Z

On Thu, Dec 12, 2019 at 12:01:29PM -0700, Jens Axboe wrote:
> @@ -2234,7 +2250,15 @@ static ssize_t generic_file_buffered_read(struct kiocb *iocb,
> error = -ENOMEM;
> goto out;
> }
> - error = add_to_page_cache_lru(page, mapping, index,
[...]
> + error = add_to_page_cache(page, mapping, index,
> mapping_gfp_constraint(mapping, GFP_KERNEL));

Surely a mistake? (and does this mistake invalidate the testing you
did earlier?)