Re: [PATCH 1/5] fs: add read support for RWF_UNCACHED

Jens Axboe
2019-12-12T21:27:29Z

On 12/12/19 2:21 PM, Matthew Wilcox wrote:
> On Thu, Dec 12, 2019 at 12:01:29PM -0700, Jens Axboe wrote:
>> @@ -2234,7 +2250,15 @@ static ssize_t generic_file_buffered_read(struct kiocb *iocb,
>> error = -ENOMEM;
>> goto out;
>> }
>> - error = add_to_page_cache_lru(page, mapping, index,
> [...]
>> + error = add_to_page_cache(page, mapping, index,
>> mapping_gfp_constraint(mapping, GFP_KERNEL));
>
> Surely a mistake? (and does this mistake invalidate the testing you
> did earlier?)

Yeah I already caught that one too - this is new in the v4 patchset, so
doesn't invalidate any of the earlier buffered testing.

--
Jens Axboe