Re: [PATCH v5 2/2] tmpfs: Support 64-bit inums per-sb

Chris Down
2020-01-10T16:45:09Z

Hi Hugh, Dave,

Hugh Dickins writes:
>Dave, Amir, Chris, many thanks for the info you've filled in -
>and absolutely no need to run any scan on your fleet for this,
>I think we can be confident that even if fb had some 15-year-old tool
>in use on its fleet of 2GB-file filesystems, it would not be the one
>to insist on a kernel revert of 64-bit tmpfs inos.
>
>The picture looks clear now: while ChrisD does need to hold on to his
>config option and inode32/inode64 mount option patch, it is much better
>left out of the kernel until (very unlikely) proved necessary.

Based on Mikael's comment above about Steam binaries, and the lack of
likelihood that they can be rebuilt, I'm inclined to still keep inode{64,32},
but make legacy behaviour require explicit opt-in. That is:

- Default it to inode64
- Remove the Kconfig option
- Only print it as an option if tmpfs was explicitly mounted with inode32

The reason I suggest keeping this is that I'm mildly concerned that the kind of
users who might be impacted by this change due to 32-bit _FILE_OFFSET_BITS --
like the not-too-uncommon case that Mikael brings up -- seem unlikely to be the
kind of people that would find it in an rc.

Other than that, the first patch could be similar to how it is now,
incorporating Hugh's improvements to the first patch to put everything under
the same stat_lock in shmem_reserve_inode.

What do you folks think?

Thanks,

Chris