From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BABA7C33CB1 for ; Wed, 15 Jan 2020 07:20:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7EF362084D for ; Wed, 15 Jan 2020 07:20:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="SGcS0CrP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7EF362084D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 17A8C8E0005; Wed, 15 Jan 2020 02:20:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 12BFA8E0003; Wed, 15 Jan 2020 02:20:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0696E8E0005; Wed, 15 Jan 2020 02:20:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0215.hostedemail.com [216.40.44.215]) by kanga.kvack.org (Postfix) with ESMTP id E72018E0003 for ; Wed, 15 Jan 2020 02:20:06 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 9DF4B180AD81A for ; Wed, 15 Jan 2020 07:20:06 +0000 (UTC) X-FDA: 76379019612.18.snow14_755527a466220 X-HE-Tag: snow14_755527a466220 X-Filterd-Recvd-Size: 2703 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Wed, 15 Jan 2020 07:20:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=mVdbeLHfuUfyQteu6gezc7j2auurEgDMNjVAHuYZ1cU=; b=SGcS0CrPzgi0h1x4I6/wpojEo PPCv8anDBT2yl/zGWcE9VxnF40muIy4yyX4zlUcfVmjzy0Doc/ue6rjLbzoXYLmFkLismJr4jmXug 4lFgTR2hyp6R53e5FTWfAFl7GYao5hbDDOqPcZB9ZX8RH1EfSjFe6qXkoBPYdi5ul5/E1Gy63+hoo nDISVOtAKa1e6yd+kup6miqdW+b0BXQ8lxEMZ2/ncr1zHTTIJygfdoyCAdc5rf4IX9ZWVENbx+xen ojlV+Xur6UjkNT1dwHhKQ9+YKbeRAsR6kJo0l9cPzWV4n8hzzRkysCvMFiQwBTyQpRJnjqwkqmYA1 y9crFL/lA==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1ircyC-0001Jf-9C; Wed, 15 Jan 2020 07:20:04 +0000 Date: Tue, 14 Jan 2020 23:20:04 -0800 From: Christoph Hellwig To: Matthew Wilcox Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Jeff Layton , Christoph Hellwig , Chris Mason Subject: Re: [PATCH v2 9/9] mm: Unify all add_to_page_cache variants Message-ID: <20200115072004.GB3460@infradead.org> References: <20200115023843.31325-1-willy@infradead.org> <20200115023843.31325-10-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200115023843.31325-10-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 14, 2020 at 06:38:43PM -0800, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > We already have various bits of add_to_page_cache() executed conditionally > on !PageHuge(page); add the add_to_page_cache_lru() pieces as some > more code which isn't executed for huge pages. This lets us remove > the old add_to_page_cache() and rename __add_to_page_cache_locked() to > add_to_page_cache(). Include a compatibility define so we don't have > to change all 20+ callers of add_to_page_cache_lru(). I'd rather change them. 20ish isn't that much after all, and not keeping pointless aliases around keeps the code easier to read.