From: Wei Yang <richardw.yang@linux.intel.com>
To: akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
mhocko@suse.com, yang.shi@linux.alibaba.com,
Wei Yang <richardw.yang@linux.intel.com>
Subject: [PATCH 7/8] mm/migrate.c: move page on next iteration
Date: Sun, 19 Jan 2020 11:06:35 +0800 [thread overview]
Message-ID: <20200119030636.11899-8-richardw.yang@linux.intel.com> (raw)
In-Reply-To: <20200119030636.11899-1-richardw.yang@linux.intel.com>
When page is not successfully queued for migration, we would move pages
on pagelist immediately. Actually, this could be done in the next
iteration by telling it we need some help.
This patch adds a new variable need_move to be an indication. After
this, we only need to call move_pages_and_store_status() twice.
Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
---
mm/migrate.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/mm/migrate.c b/mm/migrate.c
index aee5aeb082c4..2a857fec65b6 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -1610,6 +1610,7 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes,
LIST_HEAD(pagelist);
int start, i;
int err = 0, err1;
+ int need_move = 0;
migrate_prep();
@@ -1641,13 +1642,15 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes,
if (current_node == NUMA_NO_NODE) {
current_node = node;
start = i;
- } else if (node != current_node) {
+ } else if (node != current_node || need_move) {
err = move_pages_and_store_status(mm, current_node,
- &pagelist, status, start, i - start);
+ &pagelist, status, start,
+ i - start - need_move);
if (err)
goto out;
start = i;
current_node = node;
+ need_move = 0;
}
/*
@@ -1662,6 +1665,9 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes,
continue;
}
+ /* Ask next iteration to move us */
+ need_move = 1;
+
/*
* Two possible cases for err here:
* == 0: page is already on the target node, then store
@@ -1671,17 +1677,11 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes,
err = store_status(status, i, err ? : current_node, 1);
if (err)
goto out_flush;
-
- err = move_pages_and_store_status(mm, current_node, &pagelist,
- status, start, i - start);
- if (err)
- goto out;
- current_node = NUMA_NO_NODE;
}
out_flush:
/* Make sure we do not overwrite the existing error */
err1 = move_pages_and_store_status(mm, current_node, &pagelist,
- status, start, i - start);
+ status, start, i - start - need_move);
if (err >= 0)
err = err1;
out:
--
2.17.1
next prev parent reply other threads:[~2020-01-19 3:07 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-19 3:06 [PATCH 0/8] mm/migrate.c: cleanup on do_pages_move() Wei Yang
2020-01-19 3:06 ` [PATCH 1/8] mm/migrate.c: skip node check if done in last round Wei Yang
2020-01-20 9:36 ` Michal Hocko
2020-01-20 22:25 ` Wei Yang
2020-01-21 8:42 ` Michal Hocko
2020-01-22 0:36 ` Wei Yang
2020-01-22 8:16 ` Michal Hocko
2020-01-19 3:06 ` [PATCH 2/8] mm/migrate.c: not necessary to check start and i Wei Yang
2020-01-19 22:14 ` David Rientjes
2020-01-20 0:31 ` Wei Yang
2020-01-20 9:45 ` Michal Hocko
2020-01-19 3:06 ` [PATCH 3/8] mm/migrate.c: reform the last call on do_move_pages_to_node() Wei Yang
2020-01-20 9:46 ` Michal Hocko
2020-01-20 22:27 ` Wei Yang
2020-01-19 3:06 ` [PATCH 4/8] mm/migrate.c: wrap do_move_pages_to_node() and store_status() Wei Yang
2020-01-20 9:49 ` Michal Hocko
2020-01-19 3:06 ` [PATCH 5/8] mm/migrate.c: check pagelist in move_pages_and_store_status() Wei Yang
2020-01-20 9:52 ` Michal Hocko
2020-01-19 3:06 ` [PATCH 6/8] mm/migrate.c: handle same node and add failure in the same way Wei Yang
2020-01-20 10:01 ` Michal Hocko
2020-01-19 3:06 ` Wei Yang [this message]
2020-01-20 10:02 ` [PATCH 7/8] mm/migrate.c: move page on next iteration Michal Hocko
2020-01-21 1:22 ` Wei Yang
2020-01-21 8:43 ` Michal Hocko
2020-01-22 0:40 ` Wei Yang
2020-01-22 8:17 ` Michal Hocko
2020-01-19 3:06 ` [PATCH 8/8] mm/migrate.c: use break instead of goto out_flush Wei Yang
2020-01-20 10:03 ` Michal Hocko
2020-01-21 1:22 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200119030636.11899-8-richardw.yang@linux.intel.com \
--to=richardw.yang@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox