From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B95E4C33CA1 for ; Mon, 20 Jan 2020 09:36:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 662D82073D for ; Mon, 20 Jan 2020 09:36:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 662D82073D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AA8316B0612; Mon, 20 Jan 2020 04:36:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A31B06B0613; Mon, 20 Jan 2020 04:36:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8FA166B0614; Mon, 20 Jan 2020 04:36:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0050.hostedemail.com [216.40.44.50]) by kanga.kvack.org (Postfix) with ESMTP id 7611E6B0612 for ; Mon, 20 Jan 2020 04:36:50 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 403346C3C for ; Mon, 20 Jan 2020 09:36:50 +0000 (UTC) X-FDA: 76397508180.11.bean19_16f51abda832 X-HE-Tag: bean19_16f51abda832 X-Filterd-Recvd-Size: 4060 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Mon, 20 Jan 2020 09:36:49 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id d16so28744468wre.10 for ; Mon, 20 Jan 2020 01:36:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=MbCOasBOEdSpgnmOMd9yAHR0ouGjEpqXs0BkDYxSv4Q=; b=g/kDo/IWQ946p/LlNWqbioiHj3kk2OkzHk603lZPkwObjrxiKh7W59HcE9g+QOtKCi GiAWyqNQcL83gL4FFlFfgZ1kS3GDEz1F9n//7K+HcAyyR/jQJ0tL4b0Ko0O+jbhqcgSN +JbGJe18gsyTB/Vsr/orDGkZNbUoDToQUPA0OK6bV3+FJjK8HWcH6rriKhHMolTZQSIu s4WQr40QpzrSasAzGeKgkYDF5Cc+UKYRiha3g4+pqjss1/freUj5gtCmBz/gsYymPZEL 7sh0RNFqMePPMDBp2yEJKTK+92iodGNXhOnBsIp/N8SqENKH09U73fiafaz/Q61fQjQn 82FQ== X-Gm-Message-State: APjAAAVC6Cd4JUMMDPAZ6PuzsI7xwZnce0knFSmmKtJlAlgrAPAg0gnP vpzPV/MpaLOvArJ+7DjBKIBR+OZt X-Google-Smtp-Source: APXvYqxGS+Q/bpi1ot1FWRFUP5CKPAmVdWKV6iQZEi3QP3a4zdKu/vqZaGcj+HkyGtNaCBXjZXORmQ== X-Received: by 2002:adf:e6d2:: with SMTP id y18mr17108531wrm.262.1579513008584; Mon, 20 Jan 2020 01:36:48 -0800 (PST) Received: from localhost (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id y17sm665482wma.36.2020.01.20.01.36.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jan 2020 01:36:47 -0800 (PST) Date: Mon, 20 Jan 2020 10:36:46 +0100 From: Michal Hocko To: Wei Yang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, yang.shi@linux.alibaba.com Subject: Re: [PATCH 1/8] mm/migrate.c: skip node check if done in last round Message-ID: <20200120093646.GL18451@dhcp22.suse.cz> References: <20200119030636.11899-1-richardw.yang@linux.intel.com> <20200119030636.11899-2-richardw.yang@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200119030636.11899-2-richardw.yang@linux.intel.com> User-Agent: Mutt/1.12.2 (2019-09-21) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun 19-01-20 11:06:29, Wei Yang wrote: > Before move page to target node, we would check if the node id is valid. > In case we would try to move pages to the same target node, it is not > necessary to do the check each time. > > This patch tries to skip the check if the node has been checked. > > Signed-off-by: Wei Yang > --- > mm/migrate.c | 19 +++++++++++-------- > 1 file changed, 11 insertions(+), 8 deletions(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index 430fdccc733e..ba7cf4fa43a0 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -1612,15 +1612,18 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes, > goto out_flush; > addr = (unsigned long)untagged_addr(p); > > - err = -ENODEV; > - if (node < 0 || node >= MAX_NUMNODES) > - goto out_flush; > - if (!node_state(node, N_MEMORY)) > - goto out_flush; > + /* Check node if it is not checked. */ > + if (current_node == NUMA_NO_NODE || node != current_node) { > + err = -ENODEV; > + if (node < 0 || node >= MAX_NUMNODES) > + goto out_flush; > + if (!node_state(node, N_MEMORY)) > + goto out_flush; This makes the code harder to read IMHO. The original code checks the valid node first and it doesn't conflate that with the node caching logic which your change does. > > - err = -EACCES; > - if (!node_isset(node, task_nodes)) > - goto out_flush; > + err = -EACCES; > + if (!node_isset(node, task_nodes)) > + goto out_flush; > + } > > if (current_node == NUMA_NO_NODE) { > current_node = node; > -- > 2.17.1 -- Michal Hocko SUSE Labs