From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BB04C2D0DB for ; Mon, 20 Jan 2020 12:33:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3E5A321D7E for ; Mon, 20 Jan 2020 12:33:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E5A321D7E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CE2C36B0644; Mon, 20 Jan 2020 07:33:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C93FF6B0647; Mon, 20 Jan 2020 07:33:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B822D6B0648; Mon, 20 Jan 2020 07:33:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0185.hostedemail.com [216.40.44.185]) by kanga.kvack.org (Postfix) with ESMTP id 9F27C6B0644 for ; Mon, 20 Jan 2020 07:33:36 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 538812C78 for ; Mon, 20 Jan 2020 12:33:36 +0000 (UTC) X-FDA: 76397953632.15.love98_5990820252062 X-HE-Tag: love98_5990820252062 X-Filterd-Recvd-Size: 7144 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Mon, 20 Jan 2020 12:33:35 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jan 2020 04:33:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,342,1574150400"; d="scan'208";a="258694891" Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by fmsmga002.fm.intel.com with ESMTP; 20 Jan 2020 04:33:32 -0800 Date: Mon, 20 Jan 2020 20:33:43 +0800 From: Wei Yang To: Anshuman Khandual Cc: Wei Yang , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, rientjes@google.com Subject: Re: [Patch v2 3/4] mm/page_alloc.c: pass all bad reasons to bad_page() Message-ID: <20200120123343.GD18028@richard> Reply-To: Wei Yang References: <20200120030415.15925-1-richardw.yang@linux.intel.com> <20200120030415.15925-4-richardw.yang@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 20, 2020 at 12:03:20PM +0530, Anshuman Khandual wrote: > > >On 01/20/2020 08:34 AM, Wei Yang wrote: >> Now we can pass all bad reasons to __dump_page(). >> >> Signed-off-by: Wei Yang >> --- >> mm/page_alloc.c | 52 ++++++++++++++++++++++++++----------------------- >> 1 file changed, 28 insertions(+), 24 deletions(-) >> >> diff --git a/mm/page_alloc.c b/mm/page_alloc.c >> index a43b9d2482f2..a7b793c739fc 100644 >> --- a/mm/page_alloc.c >> +++ b/mm/page_alloc.c >> @@ -609,7 +609,7 @@ static inline int __maybe_unused bad_range(struct zone *zone, struct page *page) >> } >> #endif >> >> -static void bad_page(struct page *page, const char *reason, >> +static void bad_page(struct page *page, int nr, const char **reason, >> unsigned long bad_flags) >> { >> static unsigned long resume; >> @@ -638,7 +638,7 @@ static void bad_page(struct page *page, const char *reason, >> >> pr_alert("BUG: Bad page state in process %s pfn:%05lx\n", >> current->comm, page_to_pfn(page)); >> - __dump_page(page, 1, &reason); >> + __dump_page(page, nr, reason); >> bad_flags &= page->flags; >> if (bad_flags) >> pr_alert("bad because of flags: %#lx(%pGp)\n", >> @@ -1027,27 +1027,25 @@ static inline bool page_expected_state(struct page *page, >> >> static void free_pages_check_bad(struct page *page) >> { >> - const char *bad_reason; >> - unsigned long bad_flags; >> - >> - bad_reason = NULL; >> - bad_flags = 0; >> + const char *bad_reason[5]; > >s/5/NR_BAD_PAGE_REASONS > > >> + unsigned long bad_flags = 0; >> + int nr = 0; >> >> if (unlikely(atomic_read(&page->_mapcount) != -1)) >> - bad_reason = "nonzero mapcount"; >> + bad_reason[nr++] = "nonzero mapcount"; >> if (unlikely(page->mapping != NULL)) >> - bad_reason = "non-NULL mapping"; >> + bad_reason[nr++] = "non-NULL mapping"; >> if (unlikely(page_ref_count(page) != 0)) >> - bad_reason = "nonzero _refcount"; >> + bad_reason[nr++] = "nonzero _refcount"; >> if (unlikely(page->flags & PAGE_FLAGS_CHECK_AT_FREE)) { >> - bad_reason = "PAGE_FLAGS_CHECK_AT_FREE flag(s) set"; >> + bad_reason[nr++] = "PAGE_FLAGS_CHECK_AT_FREE flag(s) set"; >> bad_flags = PAGE_FLAGS_CHECK_AT_FREE; >> } >> #ifdef CONFIG_MEMCG >> if (unlikely(page->mem_cgroup)) >> - bad_reason = "page still charged to cgroup"; >> + bad_reason[nr++] = "page still charged to cgroup"; >> #endif >> - bad_page(page, bad_reason, bad_flags); >> + bad_page(page, nr, bad_reason, bad_flags); >> } >> >> static inline int free_pages_check(struct page *page) >> @@ -1062,6 +1060,7 @@ static inline int free_pages_check(struct page *page) >> >> static int free_tail_pages_check(struct page *head_page, struct page *page) >> { >> + const char *reason; >> int ret = 1; >> >> /* >> @@ -1078,7 +1077,8 @@ static int free_tail_pages_check(struct page *head_page, struct page *page) >> case 1: >> /* the first tail page: ->mapping may be compound_mapcount() */ >> if (unlikely(compound_mapcount(page))) { >> - bad_page(page, "nonzero compound_mapcount", 0); >> + reason = "nonzero compound_mapcount"; >> + bad_page(page, 1, &reason, 0); >> goto out; >> } >> break; >> @@ -1090,17 +1090,20 @@ static int free_tail_pages_check(struct page *head_page, struct page *page) >> break; >> default: >> if (page->mapping != TAIL_MAPPING) { >> - bad_page(page, "corrupted mapping in tail page", 0); >> + reason = "corrupted mapping in tail page"; >> + bad_page(page, 1, &reason, 0); >> goto out; >> } >> break; >> } >> if (unlikely(!PageTail(page))) { >> - bad_page(page, "PageTail not set", 0); >> + reason = "PageTail not set"; >> + bad_page(page, 1, &reason, 0); >> goto out; >> } >> if (unlikely(compound_head(page) != head_page)) { >> - bad_page(page, "compound_head not consistent", 0); >> + reason = "compound_head not consistent"; >> + bad_page(page, 1, &reason, 0); >> goto out; >> } >> ret = 0; >> @@ -2041,29 +2044,30 @@ static inline void expand(struct zone *zone, struct page *page, >> >> static void check_new_page_bad(struct page *page) >> { >> - const char *bad_reason = NULL; >> + const char *bad_reason[5]; > >s/5/NR_BAD_PAGE_REASONS > >> unsigned long bad_flags = 0; >> + int nr = 0; >> >> if (unlikely(atomic_read(&page->_mapcount) != -1)) >> - bad_reason = "nonzero mapcount"; >> + bad_reason[nr++] = "nonzero mapcount"; >> if (unlikely(page->mapping != NULL)) >> - bad_reason = "non-NULL mapping"; >> + bad_reason[nr++] = "non-NULL mapping"; >> if (unlikely(page_ref_count(page) != 0)) >> - bad_reason = "nonzero _refcount"; >> + bad_reason[nr++] = "nonzero _refcount"; >> if (unlikely(page->flags & __PG_HWPOISON)) { >> /* Don't complain about hwpoisoned pages */ >> page_mapcount_reset(page); /* remove PageBuddy */ >> return; >> } >> if (unlikely(page->flags & PAGE_FLAGS_CHECK_AT_PREP)) { >> - bad_reason = "PAGE_FLAGS_CHECK_AT_PREP flag set"; >> + bad_reason[nr++] = "PAGE_FLAGS_CHECK_AT_PREP flag set"; >> bad_flags = PAGE_FLAGS_CHECK_AT_PREP; >> } >> #ifdef CONFIG_MEMCG >> if (unlikely(page->mem_cgroup)) >> - bad_reason = "page still charged to cgroup"; >> + bad_reason[nr++] = "page still charged to cgroup"; >> #endif >> - bad_page(page, bad_reason, bad_flags); >> + bad_page(page, 1, bad_reason, bad_flags); >This should be 'nr' here instead ? > Thanks, I missed this one. >> } >> >> /* >> -- Wei Yang Help you, Help me