From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, FSL_HELO_FAKE,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D9CDC2D0DB for ; Tue, 21 Jan 2020 17:45:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 252C921569 for ; Tue, 21 Jan 2020 17:45:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Tw9BVG59" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 252C921569 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CA2446B0006; Tue, 21 Jan 2020 12:45:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C2B3D6B0007; Tue, 21 Jan 2020 12:45:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF3FF6B0008; Tue, 21 Jan 2020 12:45:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0195.hostedemail.com [216.40.44.195]) by kanga.kvack.org (Postfix) with ESMTP id 9664F6B0006 for ; Tue, 21 Jan 2020 12:45:07 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 4BDA345AB for ; Tue, 21 Jan 2020 17:45:07 +0000 (UTC) X-FDA: 76402367454.06.size99_66d64b2089544 X-HE-Tag: size99_66d64b2089544 X-Filterd-Recvd-Size: 6874 Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Tue, 21 Jan 2020 17:45:06 +0000 (UTC) Received: by mail-pg1-f195.google.com with SMTP id l24so1891527pgk.2 for ; Tue, 21 Jan 2020 09:45:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=XmgSXNlNou2mcO6i9Iver2Yc4nxRNH3v9tX/ZnyaZOk=; b=Tw9BVG59m7XRkj63k6tlOCW0qP+at6a5ic3pu4R0m4DjOa6KBMwR4LDOVUIr17qMi7 eZL8QopcH/vPhj6IZiKZ5qsnU3jFo0JDWrkggQQOSuXJnjOaGIf4aXc0YmZUkpctazPN AOCSIsnCatnxUCNKDaq58Gh6DklDJqjzwNlSSpvMGYFZDWteyEUdRTJ4XDBDGvTpe2xb 7eAzPAkudjN7AZQQS5O98XP8SiDA3efHgGVW/RzL17Y6pMcxzPTSrH+RdgHflqmhYNcd PtknM3OtGiiUMA2YK+Ciu2EuOFhHq8A5tFunzJxJW6C1ij5mjE5oL4dL4uyVU8bNqoA/ 2HFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=XmgSXNlNou2mcO6i9Iver2Yc4nxRNH3v9tX/ZnyaZOk=; b=MDJ6lEOifysods1vkzdsX4z77xrsJkYBjCcpljKb5BTJxaIuk5LkPuR5KRnL1si/Yd jk32Uh4HRUgHobampXyY/B0CM1670o8AKDjl1wfibchAhrA8K8RY4aYlBT9k2Q/SNNIg ojTlPSM5N88ABHIMP+NLsg0cxOyGYG35KqzpBXr52TlK3xR+SssGbx+2JFosIKidofue VYzSb3o+qoWwU+Eswj3ZmdxetF+CwipmK+CxIbLv324XbVp3XJMNzXhWubjhYp/qaXEZ q7Ku6egSDVEcjG+q68wsHiTpZT9i/XJ4EeZihsCXo9jDLYSK+DEh3h2TyL7VyIYtdsP7 CQyQ== X-Gm-Message-State: APjAAAXgdfliBdzxgu4uyoMRAHInSqcY2iNjEuMyQQsaS8GqLykBNGhi sIFKhQVYBUdY/fKpSJ7QOZ4= X-Google-Smtp-Source: APXvYqxvIbtuBdiKMYwNvonK3LsNjuapeOvdevIDzx640w6i8heAVOmNGOckz0V4Kdo46w6neV1XfA== X-Received: by 2002:aa7:9808:: with SMTP id e8mr5707265pfl.32.1579628705390; Tue, 21 Jan 2020 09:45:05 -0800 (PST) Received: from google.com ([2620:15c:211:1:3e01:2939:5992:52da]) by smtp.gmail.com with ESMTPSA id 64sm44470694pfd.48.2020.01.21.09.45.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jan 2020 09:45:03 -0800 (PST) Date: Tue, 21 Jan 2020 09:45:01 -0800 From: Minchan Kim To: Oleksandr Natalenko Cc: Kirill Tkhai , Andrew Morton , LKML , linux-mm , linux-api@vger.kernel.org, Suren Baghdasaryan , Tim Murray , Daniel Colascione , Sandeep Patil , Sonny Rao , Brian Geffon , Michal Hocko , Johannes Weiner , Shakeel Butt , John Dias , christian.brauner@ubuntu.com, sjpark@amazon.de Subject: Re: [PATCH v2 4/5] mm/madvise: allow KSM hints for remote API Message-ID: <20200121174501.GD140922@google.com> References: <20200116235953.163318-1-minchan@kernel.org> <20200116235953.163318-5-minchan@kernel.org> <37338e14-5a55-1926-b6c1-5f98b6a6fdb5@virtuozzo.com> <20200117123400.o3ne6kazkovq4okd@butterfly.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200117123400.o3ne6kazkovq4okd@butterfly.localdomain> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 17, 2020 at 01:34:00PM +0100, Oleksandr Natalenko wrote: > Hi. > > On Fri, Jan 17, 2020 at 01:13:14PM +0300, Kirill Tkhai wrote: > > On 17.01.2020 02:59, Minchan Kim wrote: > > > From: Oleksandr Natalenko > > > > > > It all began with the fact that KSM works only on memory that is marked > > > by madvise(). And the only way to get around that is to either: > > > > > > * use LD_PRELOAD; or > > > * patch the kernel with something like UKSM or PKSM. > > > > > > (i skip ptrace can of worms here intentionally) > > > > > > To overcome this restriction, lets employ a new remote madvise API. This > > > can be used by some small userspace helper daemon that will do auto-KSM > > > job for us. > > > > > > I think of two major consumers of remote KSM hints: > > > > > > * hosts, that run containers, especially similar ones and especially in > > > a trusted environment, sharing the same runtime like Node.js; > > > > > > * heavy applications, that can be run in multiple instances, not > > > limited to opensource ones like Firefox, but also those that cannot be > > > modified since they are binary-only and, maybe, statically linked. > > > > > > Speaking of statistics, more numbers can be found in the very first > > > submission, that is related to this one [1]. For my current setup with > > > two Firefox instances I get 100 to 200 MiB saved for the second instance > > > depending on the amount of tabs. > > > > > > 1 FF instance with 15 tabs: > > > > > > $ echo "$(cat /sys/kernel/mm/ksm/pages_sharing) * 4 / 1024" | bc > > > 410 > > > > > > 2 FF instances, second one has 12 tabs (all the tabs are different): > > > > > > $ echo "$(cat /sys/kernel/mm/ksm/pages_sharing) * 4 / 1024" | bc > > > 592 > > > > > > At the very moment I do not have specific numbers for containerised > > > workload, but those should be comparable in case the containers share > > > similar/same runtime. > > > > > > [1] https://lore.kernel.org/patchwork/patch/1012142/ > > > > > > Signed-off-by: Oleksandr Natalenko > > > Signed-off-by: Minchan Kim > > > --- > > > mm/madvise.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/mm/madvise.c b/mm/madvise.c > > > index 84cffd0900f1..89557998d287 100644 > > > --- a/mm/madvise.c > > > +++ b/mm/madvise.c > > > @@ -1000,6 +1000,8 @@ process_madvise_behavior_valid(int behavior) > > > switch (behavior) { > > > case MADV_COLD: > > > case MADV_PAGEOUT: > > > + case MADV_MERGEABLE: > > > + case MADV_UNMERGEABLE: > > > return true; > > > default: > > > return false; > > > > Remote madvise on KSM parameters should be OK. > > > > One thing is madvise_behavior_valid() places MADV_MERGEABLE/UNMERGEABLE > > in #ifdef brackes, so -EINVAL is returned by madvise() syscall if KSM > > is not enabled. Here we should follow the same way for symmetry. > > > > Thanks for the suggestion. > > Minchan, shall you adopt it directly, or I should send a separate patch? I will handle it in next spin.