From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8FC5C35240 for ; Thu, 23 Jan 2020 23:44:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8FBAA2087E for ; Thu, 23 Jan 2020 23:44:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8FBAA2087E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 260846B0299; Thu, 23 Jan 2020 18:44:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 211206B029A; Thu, 23 Jan 2020 18:44:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 127886B029B; Thu, 23 Jan 2020 18:44:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0190.hostedemail.com [216.40.44.190]) by kanga.kvack.org (Postfix) with ESMTP id EE0496B0299 for ; Thu, 23 Jan 2020 18:44:40 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 8E5C0180AD802 for ; Thu, 23 Jan 2020 23:44:40 +0000 (UTC) X-FDA: 76410531120.11.hair53_ba203177964c X-HE-Tag: hair53_ba203177964c X-Filterd-Recvd-Size: 4881 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Thu, 23 Jan 2020 23:44:39 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Jan 2020 15:44:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,355,1574150400"; d="scan'208";a="260054545" Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by fmsmga002.fm.intel.com with ESMTP; 23 Jan 2020 15:43:57 -0800 Date: Fri, 24 Jan 2020 07:44:08 +0800 From: Wei Yang To: Yang Shi Cc: Wei Yang , mhocko@suse.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [v2 PATCH] mm: move_pages: report the number of non-attempted pages Message-ID: <20200123234408.GA2457@richard> Reply-To: Wei Yang References: <1579736331-85494-1-git-send-email-yang.shi@linux.alibaba.com> <20200123225940.GC29851@richard> <424a0fbb-1e9a-ca9d-ba43-cb247d7a4b67@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <424a0fbb-1e9a-ca9d-ba43-cb247d7a4b67@linux.alibaba.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 23, 2020 at 03:36:58PM -0800, Yang Shi wrote: > > >On 1/23/20 2:59 PM, Wei Yang wrote: >> On Thu, Jan 23, 2020 at 07:38:51AM +0800, Yang Shi wrote: >> > Since commit a49bd4d71637 ("mm, numa: rework do_pages_move"), >> > the semantic of move_pages() was changed to return the number of >> > non-migrated pages (failed to migration) and the call would be aborted >> > immediately if migrate_pages() returns positive value. But it didn't >> > report the number of pages that we even haven't attempted to migrate. >> > So, fix it by including non-attempted pages in the return value. >> > >> > Fixes: a49bd4d71637 ("mm, numa: rework do_pages_move") >> > Suggested-by: Michal Hocko >> > Cc: Wei Yang >> > Cc: [4.17+] >> > Signed-off-by: Yang Shi >> > --- >> > v2: Rebased on top of the latest mainline kernel per Andrew >> > >> > mm/migrate.c | 24 ++++++++++++++++++++++-- >> > 1 file changed, 22 insertions(+), 2 deletions(-) >> > >> > diff --git a/mm/migrate.c b/mm/migrate.c >> > index 86873b6..9b8eb5d 100644 >> > --- a/mm/migrate.c >> > +++ b/mm/migrate.c >> > @@ -1627,8 +1627,18 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes, >> > start = i; >> > } else if (node != current_node) { >> > err = do_move_pages_to_node(mm, &pagelist, current_node); >> > - if (err) >> > + if (err) { >> > + /* >> > + * Positive err means the number of failed >> > + * pages to migrate. Since we are going to >> > + * abort and return the number of non-migrated >> > + * pages, so need incude the rest of the >> > + * nr_pages that have not attempted as well. >> > + */ >> > + if (err > 0) >> > + err += nr_pages - i - 1; >> > goto out; >> > + } >> > err = store_status(status, start, current_node, i - start); >> > if (err) >> > goto out; >> > @@ -1659,8 +1669,11 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes, >> > goto out_flush; >> > >> > err = do_move_pages_to_node(mm, &pagelist, current_node); >> > - if (err) >> > + if (err) { >> > + if (err > 0) >> > + err += nr_pages - i - 1; >> > goto out; >> > + } >> > if (i > start) { >> > err = store_status(status, start, current_node, i - start); >> > if (err) >> > @@ -1674,6 +1687,13 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes, >> > >> > /* Make sure we do not overwrite the existing error */ >> > err1 = do_move_pages_to_node(mm, &pagelist, current_node); >> > + /* >> > + * Don't have to report non-attempted pages here since: >> In previous comment, you use "non-migrated". Here is "non-attempted". What's >> the difference? > >In that comment "non-migrated" includes both reported by migrate_pages() and >the non-attempted. > ok, I see the difference. >> >> > + * - If the above loop is done gracefully there is not non-attempted >> > + * page. >> > + * - If the above loop is aborted to it means more fatal error >> > + * happened, should return err. >> > + */ >> > if (!err1) >> > err1 = store_status(status, start, current_node, i - start); >> > if (!err) >> > -- >> > 1.8.3.1 -- Wei Yang Help you, Help me