From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 840FDC32771 for ; Sat, 25 Jan 2020 01:36:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 44AA22072C for ; Sat, 25 Jan 2020 01:36:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="pMkH+xX7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44AA22072C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 466666B0010; Fri, 24 Jan 2020 20:36:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C9DA6B026C; Fri, 24 Jan 2020 20:36:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EED7A6B0266; Fri, 24 Jan 2020 20:35:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0075.hostedemail.com [216.40.44.75]) by kanga.kvack.org (Postfix) with ESMTP id AD9886B0010 for ; Fri, 24 Jan 2020 20:35:59 -0500 (EST) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 6379845C1 for ; Sat, 25 Jan 2020 01:35:59 +0000 (UTC) X-FDA: 76414440438.01.thumb07_1725122dd1032 X-HE-Tag: thumb07_1725122dd1032 X-Filterd-Recvd-Size: 3149 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Sat, 25 Jan 2020 01:35:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=LKEoyUCzBuRkKfb9R2uO7LHx4Md5GqeUkIse+rddq2w=; b=pMkH+xX7Mh/vUpdwz79LTeziBB 3XC3tlxILQETgjOioy3xvNGrkOukMURtUFt1NoWkvIC92bZYlpLVClbHUGN1Y3bqZJJ6cYtHKYcLY OeLSkurSnm6BizUAhjsDEO/UXyxI4CJj/WIqJwXDxQKJNuYRE0k2TJyDX/2mYouDTaK27C3JSt5xS rHooHWymtZLR3/WK3JZwFwDl6a/Sb8Zw8Scqb9jiV9muNkea9UQMvL+x9dSi77OU9DNLJbMH7tHDi Od5KLLqPPcdzhoysQxx/QJmzD7oeIJaEwuEf2aqZLqEDz5AvtO+0swYWAwp+CmVgbyd6nIZ0hulRy mszhOpkQ==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1ivAMd-0006VH-84; Sat, 25 Jan 2020 01:35:55 +0000 From: Matthew Wilcox To: linux-fsdevel@vger.kernel.org Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 02/12] readahead: Ignore return value of ->readpages Date: Fri, 24 Jan 2020 17:35:43 -0800 Message-Id: <20200125013553.24899-3-willy@infradead.org> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200125013553.24899-1-willy@infradead.org> References: <20200125013553.24899-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: "Matthew Wilcox (Oracle)" We used to assign the return value to a variable, which we then ignored. Remove the pretence of caring. Signed-off-by: Matthew Wilcox (Oracle) --- mm/readahead.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/mm/readahead.c b/mm/readahead.c index 6bf73ef33b7e..fc77d13af556 100644 --- a/mm/readahead.c +++ b/mm/readahead.c @@ -113,17 +113,16 @@ int read_cache_pages(struct address_space *mapping,= struct list_head *pages, =20 EXPORT_SYMBOL(read_cache_pages); =20 -static int read_pages(struct address_space *mapping, struct file *filp, +static void read_pages(struct address_space *mapping, struct file *filp, struct list_head *pages, unsigned int nr_pages, gfp_t gfp) { struct blk_plug plug; unsigned page_idx; - int ret; =20 blk_start_plug(&plug); =20 if (mapping->a_ops->readpages) { - ret =3D mapping->a_ops->readpages(filp, mapping, pages, nr_pages); + mapping->a_ops->readpages(filp, mapping, pages, nr_pages); /* Clean up the remaining pages */ put_pages_list(pages); goto out; @@ -136,12 +135,9 @@ static int read_pages(struct address_space *mapping,= struct file *filp, mapping->a_ops->readpage(filp, page); put_page(page); } - ret =3D 0; =20 out: blk_finish_plug(&plug); - - return ret; } =20 /* --=20 2.24.1