From: Wei Yang <richardw.yang@linux.intel.com>
To: akpm@linux-foundation.org
Cc: mhocko@suse.com, yang.shi@linux.alibaba.com, rientjes@google.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Wei Yang <richardw.yang@linux.intel.com>
Subject: [Patch v3 1/4] mm/migrate.c: not necessary to check start and i
Date: Sun, 26 Jan 2020 18:26:20 +0800 [thread overview]
Message-ID: <20200126102623.9616-2-richardw.yang@linux.intel.com> (raw)
In-Reply-To: <20200126102623.9616-1-richardw.yang@linux.intel.com>
Till here, i must no less than start. And if i equals to start,
store_status() would always return 0.
Remove some unnecessary check to make it easy to read and prepare for
further cleanup.
Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Acked-by: Michal Hocko <mhocko@suse.com>
---
mm/migrate.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/mm/migrate.c b/mm/migrate.c
index 6a6c8f247bce..ae3db45c6a42 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -1674,11 +1674,9 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes,
err += nr_pages - i - 1;
goto out;
}
- if (i > start) {
- err = store_status(status, start, current_node, i - start);
- if (err)
- goto out;
- }
+ err = store_status(status, start, current_node, i - start);
+ if (err)
+ goto out;
current_node = NUMA_NO_NODE;
}
out_flush:
--
2.17.1
next prev parent reply other threads:[~2020-01-26 10:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-26 10:26 [Patch v3 0/4] cleanup on do_pages_move() Wei Yang
2020-01-26 10:26 ` Wei Yang [this message]
2020-01-26 10:26 ` [Patch v3 2/4] mm/migrate.c: wrap do_move_pages_to_node() and store_status() Wei Yang
2020-01-27 9:36 ` Michal Hocko
2020-01-28 0:31 ` Wei Yang
2020-01-26 10:26 ` [Patch v3 3/4] mm/migrate.c: check pagelist in move_pages_and_store_status() Wei Yang
2020-01-26 10:26 ` [Patch v3 4/4] mm/migrate.c: handle same node and add failure in the same way Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200126102623.9616-2-richardw.yang@linux.intel.com \
--to=richardw.yang@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=rientjes@google.com \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).