From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59C20C35247 for ; Mon, 27 Jan 2020 02:59:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1EB1720842 for ; Mon, 27 Jan 2020 02:59:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="pkR1ldAG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1EB1720842 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A84EF6B0003; Sun, 26 Jan 2020 21:59:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A35976B0006; Sun, 26 Jan 2020 21:59:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94C096B0007; Sun, 26 Jan 2020 21:59:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0028.hostedemail.com [216.40.44.28]) by kanga.kvack.org (Postfix) with ESMTP id 808CD6B0003 for ; Sun, 26 Jan 2020 21:59:54 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 389D72DFD for ; Mon, 27 Jan 2020 02:59:54 +0000 (UTC) X-FDA: 76421909508.22.watch03_90a146b7b283a X-HE-Tag: watch03_90a146b7b283a X-Filterd-Recvd-Size: 3925 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Mon, 27 Jan 2020 02:59:53 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6934F20720; Mon, 27 Jan 2020 02:59:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580093992; bh=Xxe6e1RbtGn4/jUYrlDkK2iVd7wbKVCAUBJPGAeGEvk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pkR1ldAGILY7ByaZeZKE51wQBHl8Rev9VIgD1Rt2qUp2zzEeiDsmpCWuBmo3k3K/K zT01gJcoa9jeN+LW5t1rUwsYtJ8ULwZKlofyZvEhLrdRV9bcfQ3ZSiC39VrgC+r3vt SzwnOuNGl0WXlnG1/ar5Gqf5ncnnydrUK59NBVg4= Date: Sun, 26 Jan 2020 18:59:51 -0800 From: Andrew Morton To: Dmitry Osipenko Cc: Wei Yang , dan.j.williams@intel.com, aneesh.kumar@linux.ibm.com, kirill@shutemov.name, yang.shi@linux.alibaba.com, thellstrom@vmware.com, Thierry Reding , Jon Hunter , linux-kernel@vger.kernel.org, linux-mm@kvack.org, "linux-tegra@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Russell King - ARM Linux Subject: Re: [PATCH 3/5] mm/mremap: use pmd_addr_end to calculate next in move_page_tables() Message-Id: <20200126185951.c9246349befcccce210a4ab8@linux-foundation.org> In-Reply-To: <7147774a-14e9-4ff3-1548-4565f0d214d5@gmail.com> References: <20200117232254.2792-1-richardw.yang@linux.intel.com> <20200117232254.2792-4-richardw.yang@linux.intel.com> <7147774a-14e9-4ff3-1548-4565f0d214d5@gmail.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 26 Jan 2020 17:47:57 +0300 Dmitry Osipenko wro= te: > 18.01.2020 02:22, Wei Yang =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > Use the general helper instead of do it by hand. > >=20 > > Signed-off-by: Wei Yang > > --- > > mm/mremap.c | 7 ++----- > > 1 file changed, 2 insertions(+), 5 deletions(-) > >=20 > > diff --git a/mm/mremap.c b/mm/mremap.c > > index c2af8ba4ba43..a258914f3ee1 100644 > > --- a/mm/mremap.c > > +++ b/mm/mremap.c > > @@ -253,11 +253,8 @@ unsigned long move_page_tables(struct vm_area_st= ruct *vma, > > =20 > > for (; old_addr < old_end; old_addr +=3D extent, new_addr +=3D exte= nt) { > > cond_resched(); > > - next =3D (old_addr + PMD_SIZE) & PMD_MASK; > > - /* even if next overflowed, extent below will be ok */ > > + next =3D pmd_addr_end(old_addr, old_end); > > extent =3D next - old_addr; > > - if (extent > old_end - old_addr) > > - extent =3D old_end - old_addr; > > old_pmd =3D get_old_pmd(vma->vm_mm, old_addr); > > if (!old_pmd) > > continue; > > @@ -301,7 +298,7 @@ unsigned long move_page_tables(struct vm_area_str= uct *vma, > > =20 > > if (pte_alloc(new_vma->vm_mm, new_pmd)) > > break; > > - next =3D (new_addr + PMD_SIZE) & PMD_MASK; > > + next =3D pmd_addr_end(new_addr, new_addr + len); > > if (extent > next - new_addr) > > extent =3D next - new_addr; > > move_ptes(vma, old_pmd, old_addr, old_addr + extent, new_vma, > >=20 >=20 > Hello Wei, >=20 > Starting with next-20200122, I'm seeing the following in KMSG on NVIDIA > Tegra (ARM32): >=20 > BUG: Bad rss-counter state mm:(ptrval) type:MM_ANONPAGES val:190 >=20 > and eventually kernel hangs. >=20 > Git's bisection points to this patch and reverting it helps. Please fix= , > thanks in advance. Thanks. I had these tagged for 5.7-rc1 anyway, so I'll drop all five patches.