From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E831BC33CB7 for ; Mon, 27 Jan 2020 11:04:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AE9CD20661 for ; Mon, 27 Jan 2020 11:04:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IT1ZIiqU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE9CD20661 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 60DE56B0008; Mon, 27 Jan 2020 06:04:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 547196B000A; Mon, 27 Jan 2020 06:04:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 435E56B000C; Mon, 27 Jan 2020 06:04:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0253.hostedemail.com [216.40.44.253]) by kanga.kvack.org (Postfix) with ESMTP id 2B04D6B0008 for ; Mon, 27 Jan 2020 06:04:46 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id EA4532C37 for ; Mon, 27 Jan 2020 11:04:45 +0000 (UTC) X-FDA: 76423131330.08.coal02_c7631dcc6846 X-HE-Tag: coal02_c7631dcc6846 X-Filterd-Recvd-Size: 3157 Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Mon, 27 Jan 2020 11:04:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580123085; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w0j/py8gkG2r+cYKJfB9pJxwgwWUNcELclm6DIYHEkk=; b=IT1ZIiqU6/hOwyjxGeovjkNwV8wnpsb2ZdSilvKG9neGJIsazzAJxo5pvVqOY9Ud0VYX2K yqXHwiHjGPUNbfDbirpDnTzByG6Q/HaO/UDHXIhrcJOnXZogYTSaDRpjKTz/sqBYxVzzxn BNewarWGztxrACBacHS5nDA9twkbdgw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-64-pJrGIMLuMM6FOFdt2B8JZQ-1; Mon, 27 Jan 2020 06:04:41 -0500 X-MC-Unique: pJrGIMLuMM6FOFdt2B8JZQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 406621083E95; Mon, 27 Jan 2020 11:04:40 +0000 (UTC) Received: from t480s.redhat.com (unknown [10.36.118.65]) by smtp.corp.redhat.com (Postfix) with ESMTP id DC542863A4; Mon, 27 Jan 2020 11:04:38 +0000 (UTC) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, David Hildenbrand , Andrew Morton , Michal Hocko Subject: [PATCH v1 3/3] mm/page_ext.c: drop pfn_present() check when onlining Date: Mon, 27 Jan 2020 12:04:24 +0100 Message-Id: <20200127110424.5757-4-david@redhat.com> In-Reply-To: <20200127110424.5757-1-david@redhat.com> References: <20200127110424.5757-1-david@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Since commit c5e79ef561b0 ("mm/memory_hotplug.c: don't allow to online/offline memory blocks with holes") we disallow to offline any memory with holes. As all boot memory is online and hotplugged memory cannot contain holes, we never online memory with holes. This present check can be dropped. Cc: Andrew Morton Cc: Michal Hocko Signed-off-by: David Hildenbrand --- mm/page_ext.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/mm/page_ext.c b/mm/page_ext.c index 4ade843ff588..a3616f7a0e9e 100644 --- a/mm/page_ext.c +++ b/mm/page_ext.c @@ -303,11 +303,8 @@ static int __meminit online_page_ext(unsigned long s= tart_pfn, VM_BUG_ON(!node_state(nid, N_ONLINE)); } =20 - for (pfn =3D start; !fail && pfn < end; pfn +=3D PAGES_PER_SECTION) { - if (!pfn_present(pfn)) - continue; + for (pfn =3D start; !fail && pfn < end; pfn +=3D PAGES_PER_SECTION) fail =3D init_section_page_ext(pfn, nid); - } if (!fail) return 0; =20 --=20 2.24.1