From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D3C7C33CB7 for ; Tue, 28 Jan 2020 00:43:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D480E2467C for ; Tue, 28 Jan 2020 00:43:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D480E2467C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7C2B06B0008; Mon, 27 Jan 2020 19:43:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 74BB76B000A; Mon, 27 Jan 2020 19:43:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 639F26B000C; Mon, 27 Jan 2020 19:43:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0156.hostedemail.com [216.40.44.156]) by kanga.kvack.org (Postfix) with ESMTP id 4AFD56B0008 for ; Mon, 27 Jan 2020 19:43:19 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 0DB612C84 for ; Tue, 28 Jan 2020 00:43:19 +0000 (UTC) X-FDA: 76425194118.11.lace19_1ce28ecaec73c X-HE-Tag: lace19_1ce28ecaec73c X-Filterd-Recvd-Size: 3778 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Tue, 28 Jan 2020 00:43:18 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jan 2020 16:42:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,371,1574150400"; d="scan'208";a="261266505" Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by fmsmga002.fm.intel.com with ESMTP; 27 Jan 2020 16:42:48 -0800 Date: Tue, 28 Jan 2020 08:43:01 +0800 From: Wei Yang To: Dmitry Osipenko Cc: Wei Yang , akpm@linux-foundation.org, dan.j.williams@intel.com, aneesh.kumar@linux.ibm.com, kirill@shutemov.name, yang.shi@linux.alibaba.com, thellstrom@vmware.com, Thierry Reding , Jon Hunter , linux-kernel@vger.kernel.org, linux-mm@kvack.org, "linux-tegra@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Russell King - ARM Linux Subject: Re: [PATCH 3/5] mm/mremap: use pmd_addr_end to calculate next in move_page_tables() Message-ID: <20200128004301.GD20624@richard> Reply-To: Wei Yang References: <20200117232254.2792-1-richardw.yang@linux.intel.com> <20200117232254.2792-4-richardw.yang@linux.intel.com> <7147774a-14e9-4ff3-1548-4565f0d214d5@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <7147774a-14e9-4ff3-1548-4565f0d214d5@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jan 26, 2020 at 05:47:57PM +0300, Dmitry Osipenko wrote: >18.01.2020 02:22, Wei Yang =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> Use the general helper instead of do it by hand. >>=20 >> Signed-off-by: Wei Yang >> --- >> mm/mremap.c | 7 ++----- >> 1 file changed, 2 insertions(+), 5 deletions(-) >>=20 >> diff --git a/mm/mremap.c b/mm/mremap.c >> index c2af8ba4ba43..a258914f3ee1 100644 >> --- a/mm/mremap.c >> +++ b/mm/mremap.c >> @@ -253,11 +253,8 @@ unsigned long move_page_tables(struct vm_area_str= uct *vma, >> =20 >> for (; old_addr < old_end; old_addr +=3D extent, new_addr +=3D exten= t) { >> cond_resched(); >> - next =3D (old_addr + PMD_SIZE) & PMD_MASK; >> - /* even if next overflowed, extent below will be ok */ >> + next =3D pmd_addr_end(old_addr, old_end); >> extent =3D next - old_addr; >> - if (extent > old_end - old_addr) >> - extent =3D old_end - old_addr; >> old_pmd =3D get_old_pmd(vma->vm_mm, old_addr); >> if (!old_pmd) >> continue; >> @@ -301,7 +298,7 @@ unsigned long move_page_tables(struct vm_area_stru= ct *vma, >> =20 >> if (pte_alloc(new_vma->vm_mm, new_pmd)) >> break; >> - next =3D (new_addr + PMD_SIZE) & PMD_MASK; >> + next =3D pmd_addr_end(new_addr, new_addr + len); >> if (extent > next - new_addr) >> extent =3D next - new_addr; >> move_ptes(vma, old_pmd, old_addr, old_addr + extent, new_vma, >>=20 > >Hello Wei, > >Starting with next-20200122, I'm seeing the following in KMSG on NVIDIA >Tegra (ARM32): > > BUG: Bad rss-counter state mm:(ptrval) type:MM_ANONPAGES val:190 > Thanks. Would you mind letting me know which case you are testing? Or the special thing is 32-bit platform? >and eventually kernel hangs. > >Git's bisection points to this patch and reverting it helps. Please fix, >thanks in advance. --=20 Wei Yang Help you, Help me