From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C64FFC33C9E for ; Wed, 29 Jan 2020 00:32:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9E5432467E for ; Wed, 29 Jan 2020 00:32:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9E5432467E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4A4D76B0003; Tue, 28 Jan 2020 19:32:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 454D96B0005; Tue, 28 Jan 2020 19:32:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3442E6B0006; Tue, 28 Jan 2020 19:32:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0076.hostedemail.com [216.40.44.76]) by kanga.kvack.org (Postfix) with ESMTP id 1F9CD6B0003 for ; Tue, 28 Jan 2020 19:32:18 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id D0263121A for ; Wed, 29 Jan 2020 00:32:17 +0000 (UTC) X-FDA: 76428795114.16.toes12_8862af220392c X-HE-Tag: toes12_8862af220392c X-Filterd-Recvd-Size: 2090 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Wed, 29 Jan 2020 00:32:17 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Jan 2020 16:31:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,375,1574150400"; d="scan'208";a="229457123" Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by orsmga003.jf.intel.com with ESMTP; 28 Jan 2020 16:31:48 -0800 Date: Wed, 29 Jan 2020 08:32:00 +0800 From: Wei Yang To: David Hildenbrand Cc: Wei Yang , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, mhocko@suse.com, yang.shi@linux.alibaba.com, rientjes@google.com Subject: Re: [Patch v2 1/4] mm/migrate.c: not necessary to check start and i Message-ID: <20200129003200.GB12835@richard> Reply-To: Wei Yang References: <20200122011647.13636-1-richardw.yang@linux.intel.com> <20200122011647.13636-2-richardw.yang@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000127, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 28, 2020 at 11:04:23AM +0100, David Hildenbrand wrote: >On 22.01.20 02:16, Wei Yang wrote: >> Till here, i must no less than start. And if i equals to start, >> store_status() would always return 0. > >I'd suggest > >" >mm/migrate.c: no need to check for i > start in do_pages_move() > >At this point, we always have i >= start. If i == start, store_status() >will return 0. So we can drop the check for i > start. >" > >Reviewed-by: David Hildenbrand > Thanks, I took it. -- Wei Yang Help you, Help me