From: Wei Yang <richardw.yang@linux.intel.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Wei Yang <richardw.yang@linux.intel.com>,
akpm@linux-foundation.org, aneesh.kumar@linux.ibm.com,
kirill@shutemov.name, dan.j.williams@intel.com,
yang.shi@linux.alibaba.com, thellstrom@vmware.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [Patch v2 0/4] mm/mremap: cleanup move_page_tables() a little
Date: Fri, 31 Jan 2020 07:05:07 +0800 [thread overview]
Message-ID: <20200130230507.GA15192@richard> (raw)
In-Reply-To: <50f408bd-502e-bd02-53d4-719300736ce2@gmail.com>
On Fri, Jan 31, 2020 at 01:18:00AM +0300, Dmitry Osipenko wrote:
>29.01.2020 03:26, Wei Yang пишет:
>> move_page_tables() tries to move page table by PMD or PTE.
>>
>> The root reason is if it tries to move PMD, both old and new range should
>> be PMD aligned. But current code calculate old range and new range
>> separately. This leads to some redundant check and calculation.
>>
>> This cleanup tries to consolidate the range check in one place to reduce
>> some extra range handling.
>>
>> v2:
>> * remove 3rd patch which doesn't work on ARM platform. Thanks report from
>> Dmitry Osipenko
>>
>> Wei Yang (4):
>> mm/mremap: format the check in move_normal_pmd() same as
>> move_huge_pmd()
>> mm/mremap: it is sure to have enough space when extent meets
>> requirement
>> mm/mremap: calculate extent in one place
>> mm/mremap: start addresses are properly aligned
>>
>> include/linux/huge_mm.h | 2 +-
>> mm/huge_memory.c | 8 +-------
>> mm/mremap.c | 17 ++++++-----------
>> 3 files changed, 8 insertions(+), 19 deletions(-)
>>
>
>Hello Wei,
>
>I haven't noticed any problems using the v2. Thank you very much for
>addressing the problem!
>
Glad to hear this.
Actually, really thanks for your patience on testing and reporting the
problem.
Have a nice day :-)
>Tested-by: Dmitry Osipenko <digetx@gmail.com>
--
Wei Yang
Help you, Help me
prev parent reply other threads:[~2020-01-30 23:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 0:26 [Patch v2 0/4] mm/mremap: cleanup move_page_tables() a little Wei Yang
2020-01-29 0:26 ` [Patch v2 1/4] mm/mremap: format the check in move_normal_pmd() same as move_huge_pmd() Wei Yang
2020-01-29 0:26 ` [Patch v2 2/4] mm/mremap: it is sure to have enough space when extent meets requirement Wei Yang
2020-01-29 0:26 ` [Patch v2 3/4] mm/mremap: calculate extent in one place Wei Yang
2020-01-29 0:26 ` [Patch v2 4/4] mm/mremap: start addresses are properly aligned Wei Yang
2020-01-30 22:18 ` [Patch v2 0/4] mm/mremap: cleanup move_page_tables() a little Dmitry Osipenko
2020-01-30 23:05 ` Wei Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200130230507.GA15192@richard \
--to=richardw.yang@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=dan.j.williams@intel.com \
--cc=digetx@gmail.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=thellstrom@vmware.com \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).