From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1860C33CB3 for ; Thu, 30 Jan 2020 23:04:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 66FEB2063A for ; Thu, 30 Jan 2020 23:04:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 66FEB2063A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F39786B039F; Thu, 30 Jan 2020 18:04:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EEC836B03A1; Thu, 30 Jan 2020 18:04:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E27FC6B03AB; Thu, 30 Jan 2020 18:04:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0098.hostedemail.com [216.40.44.98]) by kanga.kvack.org (Postfix) with ESMTP id CE14A6B039F for ; Thu, 30 Jan 2020 18:04:56 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 82BC54405 for ; Thu, 30 Jan 2020 23:04:56 +0000 (UTC) X-FDA: 76435832592.17.mist00_482ce2d372e1f X-HE-Tag: mist00_482ce2d372e1f X-Filterd-Recvd-Size: 2979 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Thu, 30 Jan 2020 23:04:55 +0000 (UTC) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jan 2020 15:04:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,383,1574150400"; d="scan'208";a="218436177" Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by orsmga007.jf.intel.com with ESMTP; 30 Jan 2020 15:04:52 -0800 Date: Fri, 31 Jan 2020 07:05:07 +0800 From: Wei Yang To: Dmitry Osipenko Cc: Wei Yang , akpm@linux-foundation.org, aneesh.kumar@linux.ibm.com, kirill@shutemov.name, dan.j.williams@intel.com, yang.shi@linux.alibaba.com, thellstrom@vmware.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [Patch v2 0/4] mm/mremap: cleanup move_page_tables() a little Message-ID: <20200130230507.GA15192@richard> Reply-To: Wei Yang References: <20200129002642.13508-1-richardw.yang@linux.intel.com> <50f408bd-502e-bd02-53d4-719300736ce2@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <50f408bd-502e-bd02-53d4-719300736ce2@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 31, 2020 at 01:18:00AM +0300, Dmitry Osipenko wrote: >29.01.2020 03:26, Wei Yang =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> move_page_tables() tries to move page table by PMD or PTE. >>=20 >> The root reason is if it tries to move PMD, both old and new range sho= uld >> be PMD aligned. But current code calculate old range and new range >> separately. This leads to some redundant check and calculation. >>=20 >> This cleanup tries to consolidate the range check in one place to redu= ce >> some extra range handling. >>=20 >> v2: >> * remove 3rd patch which doesn't work on ARM platform. Thanks report= from >> Dmitry Osipenko >>=20 >> Wei Yang (4): >> mm/mremap: format the check in move_normal_pmd() same as >> move_huge_pmd() >> mm/mremap: it is sure to have enough space when extent meets >> requirement >> mm/mremap: calculate extent in one place >> mm/mremap: start addresses are properly aligned >>=20 >> include/linux/huge_mm.h | 2 +- >> mm/huge_memory.c | 8 +------- >> mm/mremap.c | 17 ++++++----------- >> 3 files changed, 8 insertions(+), 19 deletions(-) >>=20 > >Hello Wei, > >I haven't noticed any problems using the v2. Thank you very much for >addressing the problem! > Glad to hear this. Actually, really thanks for your patience on testing and reporting the problem. Have a nice day :-) >Tested-by: Dmitry Osipenko --=20 Wei Yang Help you, Help me