From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D90BC33CB2 for ; Fri, 31 Jan 2020 06:17:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E555E2173E for ; Fri, 31 Jan 2020 06:17:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="SK/6oF0Y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E555E2173E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 82ECF6B0595; Fri, 31 Jan 2020 01:17:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 790D66B0597; Fri, 31 Jan 2020 01:17:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 632936B0598; Fri, 31 Jan 2020 01:17:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0216.hostedemail.com [216.40.44.216]) by kanga.kvack.org (Postfix) with ESMTP id 3B40B6B0595 for ; Fri, 31 Jan 2020 01:17:09 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id E54794DAE for ; Fri, 31 Jan 2020 06:17:08 +0000 (UTC) X-FDA: 76436921736.19.sock01_3e633ec383f12 X-HE-Tag: sock01_3e633ec383f12 X-Filterd-Recvd-Size: 2178 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Fri, 31 Jan 2020 06:17:08 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D1D922082E; Fri, 31 Jan 2020 06:17:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580451428; bh=FQhKuNgik0+kXQNSNVE8jhijusSvEjZhTQNQ/llEuYs=; h=Date:From:To:Subject:In-Reply-To:From; b=SK/6oF0YNynhQR9LqBnAaJpfz1mgxTJs6iVs0xUl6UCfkEwHjFoUvyHPGY048uzMF EP72OQFq+1ZYJIT3TTB7dI1ba1leFYemn/u448ISbdweatM5RvsBzBKaLmRuGPtvwD j4FMDJIr/B/WbrQH3xC5f+yLaqeow0eafwMsSfoc= Date: Thu, 30 Jan 2020 22:17:07 -0800 From: Andrew Morton To: adobriyan@gmail.com, akpm@linux-foundation.org, linux-mm@kvack.org, mm-commits@vger.kernel.org, torvalds@linux-foundation.org Subject: [patch 109/118] fs/binfmt_elf.c: coredump: delete duplicated overflow check Message-ID: <20200131061707.ZBLDkEugH%akpm@linux-foundation.org> In-Reply-To: <20200130221021.5f0211c56346d5485af07923@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Alexey Dobriyan Subject: fs/binfmt_elf.c: coredump: delete duplicated overflow check array_size() macro will do overflow check anyway. Link: http://lkml.kernel.org/r/20191222144009.GB24341@avx2 Signed-off-by: Alexey Dobriyan Signed-off-by: Andrew Morton --- fs/binfmt_elf.c | 2 -- 1 file changed, 2 deletions(-) --- a/fs/binfmt_elf.c~elf-coredump-delete-duplicated-overflow-check +++ a/fs/binfmt_elf.c @@ -2257,8 +2257,6 @@ static int elf_core_dump(struct coredump dataoff = offset = roundup(offset, ELF_EXEC_PAGESIZE); - if (segs - 1 > ULONG_MAX / sizeof(*vma_filesz)) - goto end_coredump; vma_filesz = kvmalloc(array_size(sizeof(*vma_filesz), (segs - 1)), GFP_KERNEL); if (ZERO_OR_NULL_PTR(vma_filesz)) _