From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE7DDC2D0DB for ; Fri, 31 Jan 2020 15:47:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 87734215A4 for ; Fri, 31 Jan 2020 15:47:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 87734215A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 08AEE6B05B7; Fri, 31 Jan 2020 10:47:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 03D516B05BB; Fri, 31 Jan 2020 10:47:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E6E156B05BD; Fri, 31 Jan 2020 10:47:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0252.hostedemail.com [216.40.44.252]) by kanga.kvack.org (Postfix) with ESMTP id D29FB6B05B7 for ; Fri, 31 Jan 2020 10:47:39 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 80F06181AC9BF for ; Fri, 31 Jan 2020 15:47:39 +0000 (UTC) X-FDA: 76438359438.18.brush22_5fe9a3f1e4e0a X-HE-Tag: brush22_5fe9a3f1e4e0a X-Filterd-Recvd-Size: 3204 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Fri, 31 Jan 2020 15:47:38 +0000 (UTC) Received: by mail-wm1-f68.google.com with SMTP id f129so9216593wmf.2 for ; Fri, 31 Jan 2020 07:47:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3u8hTQfD4sS33VMkuC1P4mm6uuQ9b/xEC2uCOAZWPSQ=; b=NfxbmePVA9JNI8nJnmGabIBB09L9mciAXV/TuMPueohVZyhNOS1SSnE7O4POvnsPJV 6i3k9FJN4QWEOi/8MkEPi7deshVxkEiw7eIZiaTA0nTE4OhJUYZD6H8JUwiMpbE1aqVE rZI9F4i3qzKJXz87bO5x9brhQn+V0OpvH1QFV4swXwGsYjEbxCEBOBAWyxxlRtS26hvL lKEOaqKj9gBfMyAV64vw6WXH3Pr56ARcSzuAb44yBLCUDjchXSbsinAvTI40yVObZZQz D/Eqknya2GQ9xQvuh6OcDr1oOqH+64QNdbUAjry1Z5MeWIllHboM5LQH+P7GHJCt9n5D FtfQ== X-Gm-Message-State: APjAAAWuz9llq8nqJNSwrMentcfC7as8J6vYsJnWAgLt/qyPm38up3ik k3HZZb/ayTuVfyrI9fGQbgU= X-Google-Smtp-Source: APXvYqxVZ4kbX3o5D6rzM1kzGVJZowhvqQimb9/F99TAiPHnp7TxxGEFyIi2Gtb0ybhZKWX9li5vKg== X-Received: by 2002:a1c:df41:: with SMTP id w62mr2733578wmg.1.1580485657763; Fri, 31 Jan 2020 07:47:37 -0800 (PST) Received: from localhost (ip-37-188-238-177.eurotel.cz. [37.188.238.177]) by smtp.gmail.com with ESMTPSA id n12sm11447201wmi.18.2020.01.31.07.47.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2020 07:47:36 -0800 (PST) Date: Fri, 31 Jan 2020 16:47:35 +0100 From: Michal Hocko To: Kirill Tkhai Cc: David Hildenbrand , akpm@linux-foundation.org, hannes@cmpxchg.org, shakeelb@google.com, vdavydov.dev@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm: Allocate shrinker_map on appropriate NUMA node Message-ID: <20200131154735.GA4520@dhcp22.suse.cz> References: <158047248934.390127.5043060848569612747.stgit@localhost.localdomain> <5f3fc9a9-9a22-ccc3-5971-9783b60807bc@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5f3fc9a9-9a22-ccc3-5971-9783b60807bc@virtuozzo.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri 31-01-20 18:00:51, Kirill Tkhai wrote: [...] > @@ -333,8 +333,9 @@ static int memcg_expand_one_shrinker_map(struct mem_cgroup *memcg, > /* Not yet online memcg */ > if (!old) > return 0; > - > - new = kvmalloc(sizeof(*new) + size, GFP_KERNEL); > + /* See comment in alloc_mem_cgroup_per_node_info()*/ > + tmp = node_state(nid, N_NORMAL_MEMORY) ? nid : NUMA_NO_NODE; > + new = kvmalloc_node(sizeof(*new) + size, GFP_KERNEL, tmp); > if (!new) > return -ENOMEM; I do not think this is a good pattern to copy. Why cannot you simply use kvmalloc_node with the given node? The allocator should fallback to the closest node if the given one doesn't have any memory. -- Michal Hocko SUSE Labs