From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D19BCC35253 for ; Tue, 4 Feb 2020 04:29:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6F2612084E for ; Tue, 4 Feb 2020 04:29:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ig+oIZr2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6F2612084E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CD16D6B0003; Mon, 3 Feb 2020 23:29:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C5AB46B000D; Mon, 3 Feb 2020 23:29:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B4A696B000E; Mon, 3 Feb 2020 23:29:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0129.hostedemail.com [216.40.44.129]) by kanga.kvack.org (Postfix) with ESMTP id 995396B0003 for ; Mon, 3 Feb 2020 23:29:03 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 4FCD5180AD802 for ; Tue, 4 Feb 2020 04:29:03 +0000 (UTC) X-FDA: 76451164566.29.paste53_4f028ab2eae5b X-HE-Tag: paste53_4f028ab2eae5b X-Filterd-Recvd-Size: 3300 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Tue, 4 Feb 2020 04:29:02 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6B01C20730; Tue, 4 Feb 2020 04:29:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580790542; bh=HwO7sqi638Y/oJJnAVEpghi5HgHcNiDPQkuSSveDGZM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Ig+oIZr2VqMV0VqXuDO6AEdttvOpkZO+0gIopYdoy2GcA8yN3Un9F4idDJnXyanpU ajnFUPxA7Lo1uUNevkv7lq7ufCzeBEjqYkousFrmFmHHwJjMTu9d3LRUWIySgeKEVM SW5Jpa/TjmIuyL48Zi1Pxc1kEdMyOa8bu1XpVSRo= Date: Mon, 3 Feb 2020 20:29:00 -0800 From: Andrew Morton To: Linus Torvalds Cc: Baoquan He , Dan Williams , David Hildenbrand , "Kirill A . Shutemov" , "Kirill A . Shutemov" , Linux-MM , Mel Gorman , Michal Hocko , Michal Hocko , mm-commits@vger.kernel.org, osalvador@suse.de, Pavel Tatashin , Vlastimil Babka , zhi.jin@intel.com Subject: Re: [patch 06/67] mm: factor out next_present_section_nr() Message-Id: <20200203202900.bda79c8f28ddaa63ddd8c740@linux-foundation.org> In-Reply-To: References: <20200203173311.6269a8be06a05e5a4aa08a93@linux-foundation.org> <20200204013402.UfNC2Pqe3%akpm@linux-foundation.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 4 Feb 2020 03:04:40 +0000 Linus Torvalds wrote: > On Tue, Feb 4, 2020 at 1:34 AM Andrew Morton wrote: > > > > From: David Hildenbrand > > Subject: mm: factor out next_present_section_nr() > > > > Let's move it to the header and use the shorter variant from > > mm/page_alloc.c (the original one will also check > > "__highest_present_section_nr + 1", which is not necessary). While at it, > > make the section_nr in next_pfn() const. > > > > In next_pfn(), we now return section_nr_to_pfn(-1) instead of -1 once we > > exceed __highest_present_section_nr, which doesn't make a difference i= n > > the caller as it is big enough (>=3D all sane end_pfn). > > Here, look at that "i= n". It looks like it was a MIME line-break (so > "in" was MIME-encoded and turned into "i=\nn") followed by you or > David re-flowing the text without MIME-decoding it. Yes, my MUA is not good about converting all input. I have tools to fix up the patches post-facto but changelogs have been a challenge. I have updated my nightly check-patches-for-crap-and-email-it-to-andrew script to check for this.