From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2775FC35247 for ; Mon, 3 Feb 2020 21:37:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DB0C920838 for ; Mon, 3 Feb 2020 21:37:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="MbYqw/Vx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB0C920838 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 79C516B0005; Mon, 3 Feb 2020 16:37:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 74D766B0007; Mon, 3 Feb 2020 16:37:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6636F6B0008; Mon, 3 Feb 2020 16:37:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0007.hostedemail.com [216.40.44.7]) by kanga.kvack.org (Postfix) with ESMTP id 4C8C16B0005 for ; Mon, 3 Feb 2020 16:37:28 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id F3393180AD804 for ; Mon, 3 Feb 2020 21:37:27 +0000 (UTC) X-FDA: 76450127334.18.hair41_7b58860f53821 X-HE-Tag: hair41_7b58860f53821 X-Filterd-Recvd-Size: 2606 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Mon, 3 Feb 2020 21:37:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=EeOvvWZvH50eEtBKHt08qpUyamao6FaQ0LtUnWK0t5w=; b=MbYqw/Vx49lRe78eDwZHP4w6TQ AFN++lIatMW4RPg/gX94FI0W6fBb+aofjMfYjdZf2T4WYLPc7hk9sPYr2XepIC2kngyt5oWzR5Ar4 FcAMWsZ+tpIgZdVNLm7Ys9M1agWjLMHSXX6nGIwvk4lK0hf3Khqnt0Nst+2zDuQQO3b4gBuTDHm5q /bQ67UZbBgjnmnrXWRFAE6UlKG/ETmoHmPhfKHNoLJ1mCTjO2ryl4Ix/Tak+7/1IAnzk3gFgDma21 0G622TPsNo9G0c9ZKdm+yeDwghp2gZLQnxF5JUafrOyFDT3OQZt/W836k7QOwEehg/ZwWiKWps8K7 Ne8pgJ0A==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iyjPD-0005ga-0O; Mon, 03 Feb 2020 21:37:19 +0000 Date: Mon, 3 Feb 2020 13:37:18 -0800 From: Matthew Wilcox To: Joao Martins Cc: linux-nvdimm@lists.01.org, Dan Williams , Vishal Verma , Dave Jiang , Ira Weiny , Alex Williamson , Cornelia Huck , kvm@vger.kernel.org, Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , x86@kernel.org, Liran Alon , Nikita Leshenko , Barret Rhoden , Boris Ostrovsky , Konrad Rzeszutek Wilk Subject: Re: [PATCH RFC 02/10] mm: Handle pmd entries in follow_pfn() Message-ID: <20200203213718.GL8731@bombadil.infradead.org> References: <20200110190313.17144-1-joao.m.martins@oracle.com> <20200110190313.17144-3-joao.m.martins@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200110190313.17144-3-joao.m.martins@oracle.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 10, 2020 at 07:03:05PM +0000, Joao Martins wrote: > @@ -4366,6 +4366,7 @@ EXPORT_SYMBOL(follow_pte_pmd); > int follow_pfn(struct vm_area_struct *vma, unsigned long address, > unsigned long *pfn) > { > + pmd_t *pmdpp = NULL; Please rename to 'pmdp'.