From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, FSL_HELO_FAKE,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17803C3B189 for ; Thu, 13 Feb 2020 17:08:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CEB50222C2 for ; Thu, 13 Feb 2020 17:08:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UUykb+RL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CEB50222C2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5BE476B0584; Thu, 13 Feb 2020 12:08:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 594806B0585; Thu, 13 Feb 2020 12:08:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 482AD6B0586; Thu, 13 Feb 2020 12:08:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0156.hostedemail.com [216.40.44.156]) by kanga.kvack.org (Postfix) with ESMTP id 2B7546B0584 for ; Thu, 13 Feb 2020 12:08:17 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id C4F70181AEF1A for ; Thu, 13 Feb 2020 17:08:16 +0000 (UTC) X-FDA: 76485736992.17.eyes46_654585d7a7956 X-HE-Tag: eyes46_654585d7a7956 X-Filterd-Recvd-Size: 4639 Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by imf22.hostedemail.com (Postfix) with ESMTP for ; Thu, 13 Feb 2020 17:08:15 +0000 (UTC) Received: by mail-pg1-f194.google.com with SMTP id j15so3421082pgm.6 for ; Thu, 13 Feb 2020 09:08:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=cwmRNtTZcXSptayyAZBxEOQV5KhhsA6UhdxP7QWveJ0=; b=UUykb+RLyTck9we2hEU+HBlutDbVy5OAj/ybxhRnEXujdklsJACVx/5Bgzj2CIEvFh 8uARFfH7gvW307v1lAK31+4dKBWgeov5dV+2DC3hcwMCux3xoZzO+7qkY+1S7z6f8Ar+ ioO23mzmBHDtV7B7NcDxCEdledp/TEqBwltKjTjf7GB6O+or932lqR869R+iU8U211SK ApibpKxMygqKsHNrSByn4fGnFI5uwHhohjc6h974ozA058lhgpLTJF193DoVsAZ5oHSG ES+gAxmvaqwfxBEJRz3jOItZ2VWiiQKKBr8EKC4yiI5CUPzSmVIG/pz8TBPQuYbM29Ut cerA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=cwmRNtTZcXSptayyAZBxEOQV5KhhsA6UhdxP7QWveJ0=; b=bUtRKFyb71BVY8B+9fwowWsafJ6e7bJtW3+SttI0npurizlAwJTiyWfxoCBsxS8OqG Ounlt9PYJHlfZ6GbiZj8QV69BGdY5h4l3HwlXmVoruT6HBfvOytDuwIW+L7d4ei81v9u A4fH9UMjUWX4R759wOgSgn3IcVtiZPG9K1E1u89seJT9CRryXDDhjxdgXliWjjvd+cV3 M9oHQKPLkYgGUnclloDimu13chXFyHubgyX4fL9YX2Bg/ZFi7KXmTEqlIUAab0h8IRzJ SB/j5HxHYl8PZeeQ6fDfELWIa66zAnJ92uybL5mkMDrBRyYk4jU2lm0DPqMAdksuDGoH pX+g== X-Gm-Message-State: APjAAAU/R8ad/0iyfsfmerwgBW3un+GKz346WkSRqKLm0bIc3a7GKwDq sPXb23DmhlR9h/F00UWiXCE= X-Google-Smtp-Source: APXvYqwuN/CZ5krfQve1Eey7OtDNyhFPTJrkJ7ZHF49IJ3Nf44GFnVB0IqN9DxlY22aJ29W3O9ZPUA== X-Received: by 2002:aa7:96b7:: with SMTP id g23mr14384130pfk.108.1581613694659; Thu, 13 Feb 2020 09:08:14 -0800 (PST) Received: from google.com ([2620:15c:211:1:3e01:2939:5992:52da]) by smtp.gmail.com with ESMTPSA id 64sm3836195pfd.48.2020.02.13.09.08.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Feb 2020 09:08:13 -0800 (PST) Date: Thu, 13 Feb 2020 09:08:11 -0800 From: Minchan Kim To: Alexander Duyck Cc: Andrew Morton , LKML , linux-mm , linux-api@vger.kernel.org, oleksandr@redhat.com, Suren Baghdasaryan , Tim Murray , Daniel Colascione , Sandeep Patil , Sonny Rao , Brian Geffon , Michal Hocko , Johannes Weiner , Shakeel Butt , John Dias , Joel Fernandes , Christian Brauner Subject: Re: [PATCH v4 7/8] pid: export pidfd_get_pid Message-ID: <20200213170811.GA41717@google.com> References: <20200212233946.246210-1-minchan@kernel.org> <20200212233946.246210-8-minchan@kernel.org> <6bb20b3d4e3362337e1a4c8a4be13f6acda5b0ec.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6bb20b3d4e3362337e1a4c8a4be13f6acda5b0ec.camel@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Alexander, On Wed, Feb 12, 2020 at 04:25:31PM -0800, Alexander Duyck wrote: > On Wed, 2020-02-12 at 15:39 -0800, Minchan Kim wrote: > > process_madvise syscall needs pidfd_get_pid function to translate > > pidfd to pid so this patch exports the function. > > > > Cc: Christian Brauner > > Signed-off-by: Minchan Kim > > I think you might have misunderstood my earlier comments. This should be > patch 2 in your set. What is patch 8 should be folded into you existing > patch 2 and become patch 3 with the rest of your patches shifted by 1 > since you are reordering them. > > Otherwise the code itself appears to not have changed anything so it looks > fine to me. > > Reviewed-by: Alexander Duyck It was my intention because I expect supporting both pid and pidfd would be controversial. It would make easy to revert. Thanks for the review!