From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57194C11D1B for ; Thu, 20 Feb 2020 18:35:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 21C462467B for ; Thu, 20 Feb 2020 18:35:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b="fmztncXT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 21C462467B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chrisdown.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B331D6B0008; Thu, 20 Feb 2020 13:35:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AE3A76B000A; Thu, 20 Feb 2020 13:35:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9FA596B000C; Thu, 20 Feb 2020 13:35:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0102.hostedemail.com [216.40.44.102]) by kanga.kvack.org (Postfix) with ESMTP id 895FE6B0008 for ; Thu, 20 Feb 2020 13:35:55 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 398418248047 for ; Thu, 20 Feb 2020 18:35:55 +0000 (UTC) X-FDA: 76511359470.30.shoe44_6dda839f3cc04 X-HE-Tag: shoe44_6dda839f3cc04 X-Filterd-Recvd-Size: 4532 Received: from mail-qv1-f67.google.com (mail-qv1-f67.google.com [209.85.219.67]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Thu, 20 Feb 2020 18:35:54 +0000 (UTC) Received: by mail-qv1-f67.google.com with SMTP id ek2so2362466qvb.0 for ; Thu, 20 Feb 2020 10:35:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Ui1GYJ+3TKdhDhER6hX80GC8ogMrESlUENKJdsvmiJw=; b=fmztncXTcGHJiFgzRFjgjLEip0FvqqT27efzmzqFHV75pB/K83qJ3D1hNW4E70dXeZ CJFi4rvcQHriQibThmglNljM7AMJM2WmKPyRjHJZtP1+ft4kHUBatB/TJEuTN6xxhTiN E6+kHjefonE2x7TQtlE6uRTgWbAoPRwp5TtqE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Ui1GYJ+3TKdhDhER6hX80GC8ogMrESlUENKJdsvmiJw=; b=qUi7xcoiiKK7MpyBBfRgrwexTj1PGDqbx7GECL9hU7YCB6ZRKX6XCgwjGxK967FKKs nRovpcERiYJozHcHKG3PZCmVPRWMfgxhI8HQYVEszm1/vWVOL81emcV02Bw1xaL+MqWK FaPQc+CCR8fNX4nhOaw3fwLDbKz7tvbpZcKUgD8rWniEg+7EK099X987n1bcPuhGMcem uaOjDQ0SUbqt3a+uvzhwyr7WVNB1/7OKcpPHBf3JRpNTFcayoIr3M9QmMVufhY0rYVrG kPy3ObSrT+TvisvwtCGqG7ZldmMk99Mq++gaztPRrfUE9AigCqQ0s8MxPxv1+At2vZxq d4qA== X-Gm-Message-State: APjAAAVyH4TKvrd8CbeNVx7Y5JGH12TSQnV+ng0sn8CioSSljVpkHfzo jhoExivhAefE7eyPovq2aPbNrg== X-Google-Smtp-Source: APXvYqxmnMhAcMk3lY0AI5vqnwgSVzy5Kgiji+XEXQ3tkC5VUl2qSX0E++tOv9JyuEOMeCuZhNP74Q== X-Received: by 2002:ad4:478b:: with SMTP id z11mr27009509qvy.185.1582223754273; Thu, 20 Feb 2020 10:35:54 -0800 (PST) Received: from localhost ([2620:10d:c091:500::2:a76b]) by smtp.gmail.com with ESMTPSA id g9sm226424qkl.11.2020.02.20.10.35.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Feb 2020 10:35:53 -0800 (PST) Date: Thu, 20 Feb 2020 13:35:52 -0500 From: Chris Down To: Dan Schatzberg Cc: Jens Axboe , Tejun Heo , Li Zefan , Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Hugh Dickins , Roman Gushchin , Shakeel Butt , Yang Shi , Thomas Gleixner , "open list:BLOCK LAYER" , open list , "open list:CONTROL GROUP (CGROUP)" , "open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)" Subject: Re: [PATCH v3 2/3] mm: Charge active memcg when no mm is set Message-ID: <20200220183552.GA2181061@chrisdown.name> References: <0a27b6fcbd1f7af104d7f4cf0adc6a31e0e7dd19.1582216294.git.schatzberg.dan@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <0a27b6fcbd1f7af104d7f4cf0adc6a31e0e7dd19.1582216294.git.schatzberg.dan@gmail.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Dan Schatzberg writes: >memalloc_use_memcg() worked for kernel allocations but was silently >ignored for user pages. > >This patch establishes a precedence order for who gets charged: > >1. If there is a memcg associated with the page already, that memcg is > charged. This happens during swapin. > >2. If an explicit mm is passed, mm->memcg is charged. This happens > during page faults, which can be triggered in remote VMs (eg gup). > >3. Otherwise consult the current process context. If it has configured > a current->active_memcg, use that. Otherwise, current->mm->memcg. > >Previously, if a NULL mm was passed to mem_cgroup_try_charge (case 3) it >would always charge the root cgroup. Now it looks up the current >active_memcg first (falling back to charging the root cgroup if not >set). > >Signed-off-by: Dan Schatzberg >Acked-by: Johannes Weiner >Acked-by: Tejun Heo Acked-by: Chris Down Thanks! The clarification the v2 thread for this made things clear to me.