Re: [RFC PATCH v9 09/27] x86/mm: Introduce _PAGE_DIRTY_SW

Dave Hansen
2020-04-01T19:22:08Z

On 4/1/20 12:08 PM, Yu-cheng Yu wrote:
>>> +/*
>>> + * This bit indicates a copy-on-write page, and is different from
>>> + * _PAGE_BIT_SOFT_DIRTY, which tracks which pages a task writes to.
>>> + */
>>> +#define _PAGE_BIT_DIRTY_SW _PAGE_BIT_SOFTW5 /* was written to */
>> Does it *only* indicate a copy-on-write (or copy-on-access) page? If
>> so, haven't we misnamed it?
> It indicates either a copy-on-write page or a read-only page that has been
> cow'ed. What about _PAGE_BIT_COW?

Sounds sane to me.