From: Matthew Wilcox <willy@infradead.org>
To: mateusznosek0@gmail.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
hughd@google.com, akpm@linux-foundation.org
Subject: Re: [PATCH] mm/shmem.c: Clean code by removing unnecessary assignment
Date: Sun, 1 Mar 2020 08:54:58 -0800 [thread overview]
Message-ID: <20200301165458.GO29971@bombadil.infradead.org> (raw)
In-Reply-To: <20200301152832.24595-1-mateusznosek0@gmail.com>
On Sun, Mar 01, 2020 at 04:28:32PM +0100, mateusznosek0@gmail.com wrote:
> Previously 0 was assigned to variable 'error'
> but the variable was never read before reassignemnt later.
> So the assignment can be removed.
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
next prev parent reply other threads:[~2020-03-01 16:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-01 15:28 [PATCH] mm/shmem.c: Clean code by removing unnecessary assignment mateusznosek0
2020-03-01 16:54 ` Matthew Wilcox [this message]
2020-03-02 8:54 ` Pankaj Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200301165458.GO29971@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mateusznosek0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).