From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 233D1C3F2D1 for ; Wed, 4 Mar 2020 17:06:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CE68A21775 for ; Wed, 4 Mar 2020 17:06:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UzWuKWhw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE68A21775 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7949A6B0003; Wed, 4 Mar 2020 12:06:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 746526B0005; Wed, 4 Mar 2020 12:06:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 65A956B0007; Wed, 4 Mar 2020 12:06:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0152.hostedemail.com [216.40.44.152]) by kanga.kvack.org (Postfix) with ESMTP id 4E00C6B0003 for ; Wed, 4 Mar 2020 12:06:53 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 03F4340C7 for ; Wed, 4 Mar 2020 17:06:53 +0000 (UTC) X-FDA: 76558309464.15.peace39_5920eddc84614 X-HE-Tag: peace39_5920eddc84614 X-Filterd-Recvd-Size: 4478 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Wed, 4 Mar 2020 17:06:52 +0000 (UTC) Received: by mail-wm1-f67.google.com with SMTP id x3so14531wmj.1 for ; Wed, 04 Mar 2020 09:06:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=eAvOIF6AGY3vlZ1kzI6VwMQbeJQz/suMmkKBmXk6J8Y=; b=UzWuKWhwSTJKSKcktovi82mOWChrc/f0KtLo4X5rUYd9T9r93VZEsjULHytd8lrxv5 YIjTecmQzPuwr7GMOVXPUDzk7lTvc126GlJ12boC1Sz8lUEzTYLgcL4e4+ZzBgZnaXgV yJnsaPX9X5VH511KEtLXIvytDFOzksJdNlA9OVlQIJHT1qYZpqldWsMilzD7CoLwojYe dUPg13pM6AO6vwLFYzO4RMgsvkXMOQwQ7VjuWB5iu3uobCoFQICIbneHO+1KAYyyzoAT rs+eqJyYPk72BAxEhnWCrgwDElzuYrpfn0wpJMW+tKXYEHArAEXOCq/oElUgKrHDfO1x 49+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mime-version:content-disposition:user-agent; bh=eAvOIF6AGY3vlZ1kzI6VwMQbeJQz/suMmkKBmXk6J8Y=; b=XQjJ0sNGqfe08q1R5DJsT5HtyVLPhoZ3aWI+PHXphlVfFt0oDOFF6CgEROP9LTn55C F4DMLTMV7B/jHtyys/qDvbN5Q1PNQixjfZlQgcOJ4yw/ZKKkGJ9718cmAlFWXqA3O5zz PXShaMl+F+TwM0g8Fm8Kl3AAzNPsZAyykx2x2SNZCkeXAf6nUsVpVTw1o6KLy7+cCI5L eoMgRQRAm+9+W9DCwfoyJlsZAieYZpDGVhxUAbeNr6ryKMqXFWqDVo0ryJ8tqJ7Ml4vD YwxqAWYcyaCOcncTV/iWHtSlQSlEGa54DRm6WzO+BQzsJEXXhdcg0YONzNF+Aop1VGjM 6FEw== X-Gm-Message-State: ANhLgQ0kfxPxxR87c8XBrbBfP4DRZm4cuaUtHUgwnNI0S7WwgodOCNXH esRx5qg10vREnh+8Igd/N1o= X-Google-Smtp-Source: ADFU+vs1u9SfcjF5RGIglTQpijbTZfS8yfBBuwrm2uVF6l/ojNbTblWiBQyIEcYPkcSSRfs4nBBHBQ== X-Received: by 2002:a1c:c906:: with SMTP id f6mr4622479wmb.16.1583341611386; Wed, 04 Mar 2020 09:06:51 -0800 (PST) Received: from dumbo ([83.137.6.114]) by smtp.gmail.com with ESMTPSA id o8sm4841231wmh.15.2020.03.04.09.06.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2020 09:06:50 -0800 (PST) Date: Wed, 4 Mar 2020 18:06:46 +0100 From: Domenico Andreoli To: "Darrick J. Wong" Cc: "Rafael J. Wysocki" , Linux PM , Linux Memory Management List , linux-fsdevel@vger.kernel.org, mkleinsoft@gmail.com, Christoph Hellwig , Andrew Morton , "Rafael J. Wysocki" , Len Brown , Pavel Machek Subject: [PATCH v2] hibernate: Allow uswsusp to write to swap Message-ID: <20200304170646.GA31552@dumbo> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Domenico Andreoli It turns out that there is one use case for programs being able to write to swap devices, and that is the userspace hibernation code. Quick fix: disable the S_SWAPFILE check if hibernation is configured. Fixes: dc617f29dbe5 ("vfs: don't allow writes to swap files") Reported-by: Domenico Andreoli Reported-by: Marian Klein Signed-off-by: Domenico Andreoli v2: - use hibernation_available() instead of IS_ENABLED(CONFIG_HIBERNATE) - make Fixes: point to the right commit --- fs/block_dev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Index: b/fs/block_dev.c =================================================================== --- a/fs/block_dev.c +++ b/fs/block_dev.c @@ -34,6 +34,7 @@ #include #include #include +#include #include "internal.h" struct bdev_inode { @@ -2001,7 +2002,8 @@ ssize_t blkdev_write_iter(struct kiocb * if (bdev_read_only(I_BDEV(bd_inode))) return -EPERM; - if (IS_SWAPFILE(bd_inode)) + /* uswsusp needs write permission to the swap */ + if (IS_SWAPFILE(bd_inode) && !hibernation_available()) return -ETXTBSY; if (!iov_iter_count(from))