From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F93AC10DCE for ; Tue, 10 Mar 2020 21:25:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3DFE9205F4 for ; Tue, 10 Mar 2020 21:25:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Q3ok+b0F" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3DFE9205F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CF04A6B0003; Tue, 10 Mar 2020 17:25:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CA1076B0006; Tue, 10 Mar 2020 17:25:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B900F6B0008; Tue, 10 Mar 2020 17:25:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0054.hostedemail.com [216.40.44.54]) by kanga.kvack.org (Postfix) with ESMTP id 9C65F6B0003 for ; Tue, 10 Mar 2020 17:25:36 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 7163187F3 for ; Tue, 10 Mar 2020 21:25:36 +0000 (UTC) X-FDA: 76580734272.13.clock16_4e00080b6594b X-HE-Tag: clock16_4e00080b6594b X-Filterd-Recvd-Size: 4424 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Tue, 10 Mar 2020 21:25:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583875535; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jgobs0qTpseqZbTmHY0WybtwYdY2O/krJ5/nDYbAlGc=; b=Q3ok+b0FwBNb86FtvR1imdjDeqced2hhRdozm+9vV+iWwehnTRxwAG4MYSa6cR6fcTnHHW flDMTcVT60g6s37Zmpg0105HqayftB8TEVuHY6apR8z/yiOrFjEx/CCFNBfLsem8nWR3uS Vbco4tB1wVp9YvpBhQHkj6kpaVGqRTc= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-454--JjkesgGOceSiizD4r79UQ-1; Tue, 10 Mar 2020 17:25:33 -0400 X-MC-Unique: -JjkesgGOceSiizD4r79UQ-1 Received: by mail-qv1-f70.google.com with SMTP id u5so16498qvj.10 for ; Tue, 10 Mar 2020 14:25:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PjppQBeLTkZZCecEWozf+N5VWi5ByBEgDv2ZEv1V9p0=; b=SnaDheRYqjynCC7n/0N8xG3q9E9xaL0nvlHWddf2sprAItllfr7FVaGLK+/RTAoyzr AOjkmfXifFi1EaVMZWWiCbgJrONqp5l1mrSrJZG/jBOX8MtSANEEYJsJ6P8fwrAHTjyC YnnKmWR2Va6z7zFQSk8uW43a7mxNNLAh+igqZSs1rWdcY2ndCYS5E9t1nAV47jjVoYPi ZAYr3VtO3+pPni9p0jW8S3PJxK34AEOmD5QipPnBP6a6ZxYdNAEmaARhBQJ0hJTd7IwF QKcPB9oqzRFp4WTc04QX/TwwUu76g9vYltQ11gqwVws3BsYmFQ6mOzf/x08sIxCPEPFC cj3g== X-Gm-Message-State: ANhLgQ1W2eFNcEsVlF9coY0Xj7if4BX+cJB/Np259WOzEdrouAKgw20b /CE+sMERAm5RQrzVbixK0hwsozyf9a/ViXIMKfORHdiW4Itz4yOt9SGxR6NccketIA0U21sPE0f 0vgEAia19EXc= X-Received: by 2002:a05:6214:118d:: with SMTP id t13mr180506qvv.192.1583875532912; Tue, 10 Mar 2020 14:25:32 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsm9esHy6RRQ6NWExmJI592vF5/fX7Q0wtldkoyBFRw99jepEJ3weu40LWa8dfzm4aTO5HEjg== X-Received: by 2002:a05:6214:118d:: with SMTP id t13mr180490qvv.192.1583875532728; Tue, 10 Mar 2020 14:25:32 -0700 (PDT) Received: from redhat.com (bzq-79-178-2-19.red.bezeqint.net. [79.178.2.19]) by smtp.gmail.com with ESMTPSA id n50sm3507706qtc.5.2020.03.10.14.25.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2020 14:25:31 -0700 (PDT) Date: Tue, 10 Mar 2020 17:25:25 -0400 From: "Michael S. Tsirkin" To: David Hildenbrand Cc: David Rientjes , linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtualization@lists.linux-foundation.org, Jason Wang , Stephen Rothwell , Tyler Sanderson , Wei Wang , Alexander Duyck , Nadav Amit , Michal Hocko , Andrew Morton Subject: Re: [PATCH v3] virtio-balloon: Switch back to OOM handler for VIRTIO_BALLOON_F_DEFLATE_ON_OOM Message-ID: <20200310172114-mutt-send-email-mst@kernel.org> References: <20200310113854.11515-1-david@redhat.com> <890da35b-1ac2-9c2e-b42d-96d24d3e0f4c@redhat.com> MIME-Version: 1.0 In-Reply-To: <890da35b-1ac2-9c2e-b42d-96d24d3e0f4c@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 10, 2020 at 08:13:19PM +0100, David Hildenbrand wrote: > > Should this have: > >=20 > > Cc: stable@vger.kernel.org # 4.19+ >=20 > I guess as nothing will actually "crash" it's not worth stable. No - it's a regression, it would be a stable candidate from that POV. The issue is the patch size - stable rules say: - It cannot be bigger than 100 lines, with context. This is about 200 lines with context. In practice Fixes: is enough to make a bunch of downstreams pick it up. --=20 MST