From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B9C7C10DCE for ; Tue, 10 Mar 2020 19:36:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C262020873 for ; Tue, 10 Mar 2020 19:36:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C262020873 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 506606B0005; Tue, 10 Mar 2020 15:36:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E4E06B0006; Tue, 10 Mar 2020 15:36:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3CAE06B0007; Tue, 10 Mar 2020 15:36:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0021.hostedemail.com [216.40.44.21]) by kanga.kvack.org (Postfix) with ESMTP id 245586B0005 for ; Tue, 10 Mar 2020 15:36:28 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 604C7180AD807 for ; Tue, 10 Mar 2020 19:36:27 +0000 (UTC) X-FDA: 76580459214.03.word14_8f9831af37424 X-HE-Tag: word14_8f9831af37424 X-Filterd-Recvd-Size: 3287 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Tue, 10 Mar 2020 19:36:26 +0000 (UTC) Received: by mail-wm1-f65.google.com with SMTP id r7so1510131wmg.0 for ; Tue, 10 Mar 2020 12:36:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=IQNxafXsQdCTqr3ErUs/r6IszKzwOyK1ozoK1kswePE=; b=kulPooI6pAojisvh5PkxpfH2ooSPBW8vTsb2+kOeu9MBUPyfOhG0tkD9F7IBKBD23j GNY8WCdo0dIEjHdC4GaY5KFNx/+fSpWCmwYFEg2x3hd91uOYkrTMlO6HJ23RrSMSLFKS tw13C4b26Y+OrwlWXmzcbmEDjC7CQ9s4mroe5lEgGaIYdCWrV7Djrq6AOxsAbXA4vokR 5U7aKu41TuP2gPatnSwKh+1ZMYuFjxIw3AopoBdktQZXuhw7GM73FcNtdBPB3Zwgzbur I4rOEvAAHE/HqWrMsEuxQBza503c6IQBlMwcachDAZRqKVmvRQLLcmkMz30MXX+A6MJT Ivwg== X-Gm-Message-State: ANhLgQ2pytM7tyn6pRsLdXV/7SGqIKkZ+BC4R6VByBVECq7CiKZz4MG9 hlB6TTNSMYJBemKfJQCtweQ= X-Google-Smtp-Source: ADFU+vvmBQXI6EXmODjgWFHAww7aH6QevORA++ZLDSkxDomP85/Oaa/ZB0so2d/bkib0TI6RdPGJ9Q== X-Received: by 2002:a1c:9904:: with SMTP id b4mr3635404wme.34.1583868985302; Tue, 10 Mar 2020 12:36:25 -0700 (PDT) Received: from localhost (ip-37-188-253-35.eurotel.cz. [37.188.253.35]) by smtp.gmail.com with ESMTPSA id m25sm5076945wml.35.2020.03.10.12.36.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2020 12:36:24 -0700 (PDT) Date: Tue, 10 Mar 2020 20:36:22 +0100 From: Michal Hocko To: Roman Gushchin Cc: Mike Kravetz , Andrew Morton , Johannes Weiner , linux-mm@kvack.org, kernel-team@fb.com, linux-kernel@vger.kernel.org, Rik van Riel Subject: Re: [PATCH v2] mm: hugetlb: optionally allocate gigantic hugepages using cma Message-ID: <20200310193622.GC8447@dhcp22.suse.cz> References: <20200310002524.2291595-1-guro@fb.com> <5cfa9031-fc15-2bcc-adb9-9779285ef0f7@oracle.com> <20200310180558.GD85000@carbon.dhcp.thefacebook.com> <4b78a8a9-7b5a-eb62-acaa-2677e615bea1@oracle.com> <20200310191906.GA96999@carbon.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200310191906.GA96999@carbon.dhcp.thefacebook.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 10-03-20 12:19:06, Roman Gushchin wrote: [...] > > I found this out by testing code and specifying hugetlb_cma=2M. Messages > > in log were: > > kernel: hugetlb_cma: reserve 2097152, 1048576 per node > > kernel: hugetlb_cma: successfully reserved 1048576 on node 0 > > kernel: hugetlb_cma: successfully reserved 1048576 on node 1 > > But, it really reserved 1GB per node. > > Good point! In the passed size is too small to cover a single huge page, > we should probably print a warning and bail out. Or maybe you just want to make the interface the unit size rather than overall size oriented. E.g. I want 10G pages per each numa node. -- Michal Hocko SUSE Labs