From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 355A5C10DCE for ; Tue, 10 Mar 2020 20:26:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CDFD321927 for ; Tue, 10 Mar 2020 20:26:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tCkxaKUG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CDFD321927 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 777756B0005; Tue, 10 Mar 2020 16:26:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 728186B0006; Tue, 10 Mar 2020 16:26:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5EFD56B0007; Tue, 10 Mar 2020 16:26:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0237.hostedemail.com [216.40.44.237]) by kanga.kvack.org (Postfix) with ESMTP id 43E546B0005 for ; Tue, 10 Mar 2020 16:26:14 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 037198248047 for ; Tue, 10 Mar 2020 20:26:14 +0000 (UTC) X-FDA: 76580584668.17.snake21_8da2059f5773d X-HE-Tag: snake21_8da2059f5773d X-Filterd-Recvd-Size: 4069 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by imf02.hostedemail.com (Postfix) with ESMTP for ; Tue, 10 Mar 2020 20:26:13 +0000 (UTC) Received: by mail-wm1-f66.google.com with SMTP id x3so1597305wmj.1 for ; Tue, 10 Mar 2020 13:26:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=JqYk8R4UPwKS97k6zpIyj5riBjZ7GjDwEcUa5Ekupac=; b=tCkxaKUGWKNb+HTFdm5JbBkMM4KtNpMAde+z/oWZh3mOGSVZ2p5N/0MdlVGcB8K27b 3ARO+n2hD1B00XYU/Y/P9RfKsDcCWTRsIkZYDjf1fWtRuvqJJUzrfduyJbeidLDwsxJi apRYCKwT1z4pdpgXFVifYp++iYW1EHHw4fdRZUAP5VdrWn4scSsSsvpA2uYe8u3nMsx6 4gZyM6cLKDY8khJubIx5bQR1L+922dEpo4MAtMLgJQ5/GoxL814HlZTenVZeWdeTbyuE 531KTbZpXTCmUlUfmx9MDq8sCPIlcKWJDuulZy+9563ns1wcWGpLzHpEW8qlzpfBeNSL 7/0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=JqYk8R4UPwKS97k6zpIyj5riBjZ7GjDwEcUa5Ekupac=; b=ogMk/yDZumF5B3xNoXZqrnkulvbRos/BMBE/3UIc+xtv+heZz7c63th8wV9THi9iJO RfQooJU6AMqz1UUEq/PutFZukQptLIIANhI8CnbaEM8OnPt2oo5QhvQUx06XaQ21yGPF P7bfQ7YSSMvoZ4lxtBee84XWu+K4qn9lZTIW28+awMFj+HiQ2ZYFUy48Cf+edyx7jEhz JPA2CbpXlo2L3JiNPsdQUJeNb9kkdQu/yv7h3cMNlP+zpGz+bIpKgQ8H7u40Lr2hL90z LQRjnuKsoHfoTy5ipQ2MiE3J9wrkBo0cGA3EW2HIom1q97046E4Loi4NYZdyg1Jg4vDF dJaw== X-Gm-Message-State: ANhLgQ2NswJAsCO2Au3PhacMzjzdQavc9P5eokYBBLjqGLINI0Lf6zRN dwun8US28dyGuFX/X4If/g== X-Google-Smtp-Source: ADFU+vvQS3dt6GEtid3fA+7d9DuJE3zKvSKgS14keG2HQAca41GrUO3nrwsCDXKWZ+MwILBlwMptqw== X-Received: by 2002:a1c:7e08:: with SMTP id z8mr3581832wmc.166.1583871972104; Tue, 10 Mar 2020 13:26:12 -0700 (PDT) Received: from avx2 ([46.53.249.42]) by smtp.gmail.com with ESMTPSA id c2sm5593845wma.39.2020.03.10.13.26.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2020 13:26:11 -0700 (PDT) Date: Tue, 10 Mar 2020 23:26:09 +0300 From: Alexey Dobriyan To: Anshuman Khandual Cc: Hugh Dickins , linux-mm@kvack.org, "David S. Miller" , Andrew Morton , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [RFC 3/3] mm/vma: Introduce some more VMA flag wrappers Message-ID: <20200310202609.GA6287@avx2> References: <1583131666-15531-1-git-send-email-anshuman.khandual@arm.com> <1583131666-15531-4-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 03, 2020 at 02:43:21PM +0530, Anshuman Khandual wrote: > On 03/03/2020 12:04 PM, Hugh Dickins wrote: > > On Mon, 2 Mar 2020, Anshuman Khandual wrote: > >> vma_is_dontdump() > >> vma_is_noreserve() > >> vma_is_special() > >> vma_is_locked() > >> vma_is_mergeable() > >> vma_is_softdirty() > >> vma_is_thp() > >> vma_is_nothp() > > Improved readability? Not to my eyes. > > As mentioned before, I dont feel strongly about patch 3/3 and will drop. Should be "const struct vm_area_struct *" anyway.