From: Alexey Dobriyan <adobriyan@gmail.com>
To: Jaewon Kim <jaewon31.kim@samsung.com>
Cc: akpm@linux-foundation.org, labbott@redhat.com,
sumit.semwal@linaro.org, minchan@kernel.org, ngupta@vflare.org,
sergey.senozhatsky.work@gmail.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, jaewon31.kim@gmail.com
Subject: Re: [RFC PATCH 1/3] proc/meminfo: introduce extra meminfo
Date: Wed, 11 Mar 2020 20:35:50 +0300 [thread overview]
Message-ID: <20200311173550.GA2170@avx2> (raw)
In-Reply-To: <20200311034441.23243-2-jaewon31.kim@samsung.com>
On Wed, Mar 11, 2020 at 12:44:39PM +0900, Jaewon Kim wrote:
> Provide APIs to drivers so that they can show its memory usage on
> /proc/meminfo.
>
> int register_extra_meminfo(atomic_long_t *val, int shift,
> const char *name);
> int unregister_extra_meminfo(atomic_long_t *val);
> + show_val_kb(m, memtemp->name_pad, nr_page);
I have 3 issues.
Can this be printed without "KB" piece and without useless whitespace,
like /proc/vmstat does?
I don't know how do you parse /proc/meminfo.
Do you search for specific string or do you use some kind of map[k] = v
interface?
2) zsmalloc can create top-level symlink and resolve it to necessary value.
It will be only 1 readlink(2) system call to fetch it.
3) android can do the same
For simple values there is no need to register stuff and create
mini subsystems.
/proc/alexey
next prev parent reply other threads:[~2020-03-11 17:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200311034454epcas1p2ef0c0081971dd82282583559398e58b2@epcas1p2.samsung.com>
2020-03-11 3:44 ` [RFC PATCH 0/3] meminfo: introduce extra meminfo Jaewon Kim
[not found] ` <CGME20200311034454epcas1p184680d40f89d37eec7f934074c4a9fcf@epcas1p1.samsung.com>
2020-03-11 3:44 ` [RFC PATCH 1/3] proc/meminfo: " Jaewon Kim
2020-03-11 6:18 ` Sergey Senozhatsky
2020-03-11 6:25 ` Sergey Senozhatsky
2020-03-11 6:30 ` Jaewon Kim
2020-03-11 17:35 ` Alexey Dobriyan [this message]
2020-03-13 4:53 ` Jaewon Kim
[not found] ` <CGME20200311034454epcas1p13f7806e51b19c7848148c20ce3841b1b@epcas1p1.samsung.com>
2020-03-11 3:44 ` [RFC PATCH 2/3] mm: zsmalloc: include zs page size in proc/meminfo Jaewon Kim
[not found] ` <CGME20200311034454epcas1p46f44b4c1e75fa52b7598749566228a11@epcas1p4.samsung.com>
2020-03-11 3:44 ` [RFC PATCH 3/3] android: ion: include system heap " Jaewon Kim
2020-03-11 7:25 ` [RFC PATCH 0/3] meminfo: introduce extra meminfo Leon Romanovsky
2020-03-13 4:39 ` Jaewon Kim
2020-03-13 7:21 ` Leon Romanovsky
2020-03-13 15:19 ` Vlastimil Babka
2020-03-13 17:48 ` Leon Romanovsky
2020-03-16 4:07 ` Jaewon Kim
2020-03-16 8:31 ` Leon Romanovsky
2020-03-17 3:04 ` Jaewon Kim
2020-03-17 14:37 ` Leon Romanovsky
2020-03-18 8:58 ` Jaewon Kim
2020-03-18 10:58 ` Leon Romanovsky
2020-03-20 10:00 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200311173550.GA2170@avx2 \
--to=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jaewon31.kim@gmail.com \
--cc=jaewon31.kim@samsung.com \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).