From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15E44C2BB1D for ; Mon, 16 Mar 2020 16:44:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CDCB320409 for ; Mon, 16 Mar 2020 16:44:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="YcXIeyKU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CDCB320409 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8237C6B0032; Mon, 16 Mar 2020 12:44:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D3636B0036; Mon, 16 Mar 2020 12:44:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E98C6B0037; Mon, 16 Mar 2020 12:44:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0032.hostedemail.com [216.40.44.32]) by kanga.kvack.org (Postfix) with ESMTP id 568AF6B0032 for ; Mon, 16 Mar 2020 12:44:00 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id D93D8181AEF21 for ; Mon, 16 Mar 2020 16:43:59 +0000 (UTC) X-FDA: 76601797398.14.bait25_5bef4d380b39 X-HE-Tag: bait25_5bef4d380b39 X-Filterd-Recvd-Size: 3600 Received: from mail-qt1-f193.google.com (mail-qt1-f193.google.com [209.85.160.193]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Mon, 16 Mar 2020 16:43:59 +0000 (UTC) Received: by mail-qt1-f193.google.com with SMTP id l13so14746913qtv.10 for ; Mon, 16 Mar 2020 09:43:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=rkCUg3ryagjY3vP9P2NkEOlsBRG3jJ/eRHpnH+oZdIE=; b=YcXIeyKUPFry6sg+d3uo/skceR5dpLalHOcC/YV3PSCGD+SR8Yg0tPYsOjytpMMgPm +AzU7t2kSuw11F1mltjSruq0DVfWvCg9mcxpe0al/8ydaX15m63z6uqqXSZ5xQE+ci61 ng3wtoAk5SfeJ0bXlgx8wqJTviboQpNLtT+Wv4dlnSEbMgZxSt9VWxtCU2zYz0Ahbvzn mbv6QZpaWohtQW+4eR4q5uMu1ArabJTAFBBDJaOkv0JcSZSv7XyklPpQBtBbQxrF7se6 WzqjscNcdn71bThvlfMsTEpRIrBuB2XY+7S3P4M4aE13ntuzG+erEs/Ip9APz0QcEHhZ 08xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rkCUg3ryagjY3vP9P2NkEOlsBRG3jJ/eRHpnH+oZdIE=; b=Ta+hH8rVDfgPouyT+joeloady5Q0eSJvt/fU5u0D2t7R3UUwoS/7N/WtS5NzPpA0D4 dhf8upGu6B8Wk6pcRamougxb/QqrXis/ZnhKbq8bBu2AadT/fjQSTpvs8WCsMG7bEI9X 9c8/i+SUEcPWqwLE6yneuhbAP+nZTNNAP104MGux6LC3Ua0hAH4hQ9UgFzpbaHxcZrES eZPWddNbgh+zUYjonKGmDJjn+P0sBQjTR7Hx7/qbQFDTCVQrKkqTOEXZ1V7xbJHOHRJH ra6xRngS+nA/17pXpECtWIdNf213rFau6lobnhd+b0joKs4dbwtQKQfGOakb2Faz9CkR IvFQ== X-Gm-Message-State: ANhLgQ0twu02/vf17NuAncrLym/2hpaFNj4ct0y+S6TEot2jANJaDRTG tf+t+q77s/w83vM55sQshNnnhg== X-Google-Smtp-Source: ADFU+vs6RmZJNzDaoGLKxalIv8+1SO52k84Bk/FybMGr4MFTFHMM+3doi8TLn1zlXJ7toqHH5IV83w== X-Received: by 2002:ac8:41d8:: with SMTP id o24mr1031898qtm.300.1584377038925; Mon, 16 Mar 2020 09:43:58 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id t55sm174193qte.24.2020.03.16.09.43.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 16 Mar 2020 09:43:58 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jDsqL-0007G7-Q8; Mon, 16 Mar 2020 13:43:57 -0300 Date: Mon, 16 Mar 2020 13:43:57 -0300 From: Jason Gunthorpe To: Christoph Hellwig Cc: Jerome Glisse , Ralph Campbell , linux-mm@kvack.org Subject: Re: [PATCH 3/5] mm: simplify hmm_vma_walk_hugetlb_entry Message-ID: <20200316164357.GF20941@ziepe.ca> References: <20200316135310.899364-1-hch@lst.de> <20200316135310.899364-4-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200316135310.899364-4-hch@lst.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 16, 2020 at 02:53:08PM +0100, Christoph Hellwig wrote: > Remove the rather confusing goto label and just handle the fault case > directly in the branch checking for it. > > Signed-off-by: Christoph Hellwig > --- > mm/hmm.c | 13 +++---------- > 1 file changed, 3 insertions(+), 10 deletions(-) Yep, I had a version of this too in progress Reviewed-by: Jason Gunthorpe Jason