From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D178C18E5B for ; Mon, 16 Mar 2020 16:45:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 55D5520679 for ; Mon, 16 Mar 2020 16:45:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="YPg3/p3X" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 55D5520679 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 081206B0010; Mon, 16 Mar 2020 12:45:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 058EF6B0037; Mon, 16 Mar 2020 12:45:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED7656B006C; Mon, 16 Mar 2020 12:45:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0022.hostedemail.com [216.40.44.22]) by kanga.kvack.org (Postfix) with ESMTP id D27C16B0010 for ; Mon, 16 Mar 2020 12:45:56 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 7334EEFE7 for ; Mon, 16 Mar 2020 16:45:56 +0000 (UTC) X-FDA: 76601802312.01.frogs44_16bc14df02031 X-HE-Tag: frogs44_16bc14df02031 X-Filterd-Recvd-Size: 3791 Received: from mail-qt1-f195.google.com (mail-qt1-f195.google.com [209.85.160.195]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Mon, 16 Mar 2020 16:45:56 +0000 (UTC) Received: by mail-qt1-f195.google.com with SMTP id l20so14775711qtp.4 for ; Mon, 16 Mar 2020 09:45:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=vHtV7BKXgyr7FkmyB2TD/M7s05p+ZQZBB2o89kDDVZ8=; b=YPg3/p3X9PPeiebbB/1L/d4MKP6XKyFrcgkMORBcjSQe2QzW9Y9pC+2B536zr7lQr6 oXnnMItEpuSoHCPpTg8K5GNABoJnRbYoiAm8ZzojZJoO+NBd6mtKkup+wmkp1twCKA6k tpeGQG6kGnXSGet6asxG4J+CKheswxO772+kN8R7ilWkF8SSfejp5ZT40OZSN5+DkjNM n/NmRS1pYb/KmrvuA1mX958mIYFAIVbHXrK4QALjrlXzPz1WlNAZwJxXfr3U0Cv9wqzE M7HA7wunYJK00YFoFKDiwkK3t3UzUHvWr0pDknoQWvwmXvHdJ/whhaFVbAPhst81+p4W 30nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=vHtV7BKXgyr7FkmyB2TD/M7s05p+ZQZBB2o89kDDVZ8=; b=OYZzfHo2R3/4rzMowpM+MJUq4uEaCPp9egJtd2MkofBG2jzw78vWUE1dT2IUKArID+ 3ng6exVCm9jUX4d7GUEZskJCrC5EJMWAjiQ6DFQCHXhr65dAT+EzpLjUNV7nfxKcHPQm A9vntbVtzF9aHHFhS0noVY0Djvctv/+udNbCMC9VFS51Yu+bSG2yuNuUgWiU+OjB1B9r 3CUVNdpz2lX5khRUgcTLbH+UdaP7Zf198VHhbqCxS8xE7s/wlwJsK3jZSXr6AAvf8SCu Q02oau0LFJFdjX9IvVzpY0pQsHl97+1xjz2VsbTp1RX8QOF0zmpSg4wxr9YxyUBKaYaK uLWQ== X-Gm-Message-State: ANhLgQ0atlJseARp3XSkE7xkMiKUKDL2vrsPvWAjB+dF8m1ocj8R4Io5 HY57eopIgmPzqg5h7XEdkCqzeg== X-Google-Smtp-Source: ADFU+vskxMqb7yDapMRj8v315tHn9Mz2lhqs3uooBdVVFcz4Np55Im0J2xQAJsoRLxz/OXFIBSKOXg== X-Received: by 2002:aed:3ed0:: with SMTP id o16mr997692qtf.3.1584377155710; Mon, 16 Mar 2020 09:45:55 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id 17sm99604qkm.105.2020.03.16.09.45.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 16 Mar 2020 09:45:55 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jDssE-0007H6-Sw; Mon, 16 Mar 2020 13:45:54 -0300 Date: Mon, 16 Mar 2020 13:45:54 -0300 From: Jason Gunthorpe To: Christoph Hellwig Cc: Jerome Glisse , Ralph Campbell , linux-mm@kvack.org Subject: Re: [PATCH 1/5] mm: don't provide a stub for hmm_range_fault Message-ID: <20200316164554.GH20941@ziepe.ca> References: <20200316135310.899364-1-hch@lst.de> <20200316135310.899364-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200316135310.899364-2-hch@lst.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 16, 2020 at 02:53:06PM +0100, Christoph Hellwig wrote: > All callers of hmm_range_fault depend on CONFIG_HMM_MIRROR, so > don't bother with a stub. > > Signed-off-by: Christoph Hellwig > --- > include/linux/hmm.h | 7 ------- > 1 file changed, 7 deletions(-) I agree, there is no reason not to just enable CONFIG_HMM_MIRROR if code calls it. Reviewed-by: Jason Gunthorpe Arguably at this point the config should be renamed to CONFIG_HMM_RANGE_FAULT as all it does now is enable compiling this code, there is no runtime cost or downside to enabling it. Jason