From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9702C5ACD8 for ; Mon, 16 Mar 2020 16:51:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4B4E9206C0 for ; Mon, 16 Mar 2020 16:51:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B4E9206C0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A67346B000A; Mon, 16 Mar 2020 12:51:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F0D66B000C; Mon, 16 Mar 2020 12:51:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 907266B0010; Mon, 16 Mar 2020 12:51:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0118.hostedemail.com [216.40.44.118]) by kanga.kvack.org (Postfix) with ESMTP id 795F86B000A for ; Mon, 16 Mar 2020 12:51:58 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 189A88248047 for ; Mon, 16 Mar 2020 16:51:58 +0000 (UTC) X-FDA: 76601817516.02.pear26_4b4ec8a48761b X-HE-Tag: pear26_4b4ec8a48761b X-Filterd-Recvd-Size: 1563 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Mon, 16 Mar 2020 16:51:57 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id B6AF668CEC; Mon, 16 Mar 2020 17:51:54 +0100 (CET) Date: Mon, 16 Mar 2020 17:51:54 +0100 From: Christoph Hellwig To: Jason Gunthorpe Cc: Christoph Hellwig , Jerome Glisse , Ralph Campbell , linux-mm@kvack.org Subject: Re: [PATCH 5/5] mm: merge hmm_vma_do_fault into into hmm_vma_walk_hole_ Message-ID: <20200316165154.GA22701@lst.de> References: <20200316135310.899364-1-hch@lst.de> <20200316135310.899364-6-hch@lst.de> <20200316164110.GA27591@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200316164110.GA27591@ziepe.ca> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 16, 2020 at 01:41:10PM -0300, Jason Gunthorpe wrote: > > +out_error: > > + pfns[i] = range->values[HMM_PFN_ERROR]; > > + return -EFAULT; > > I've also got a patch deleting these confusing HMM_PFN_ERRORs. They > are not applied consistently and no caller would scan the output for > ERROR on some failures. For instance the above doesn't set it on EPERM. > > So this can just be 'return -EFAULT' instead of 'goto out_error' > > I can fold that in if you agree: If you want to fix this up and the other ->pfns initialization feel free. Otherwise I'd be happy to resend.