From: Christoph Hellwig <hch@lst.de>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Christoph Hellwig <hch@lst.de>,
Jerome Glisse <jglisse@redhat.com>,
Ralph Campbell <rcampbell@nvidia.com>,
linux-mm@kvack.org
Subject: Re: [PATCH 5/5] mm: merge hmm_vma_do_fault into into hmm_vma_walk_hole_
Date: Mon, 16 Mar 2020 19:01:31 +0100 [thread overview]
Message-ID: <20200316180131.GA24031@lst.de> (raw)
In-Reply-To: <20200316165154.GA22701@lst.de>
On Mon, Mar 16, 2020 at 05:51:54PM +0100, Christoph Hellwig wrote:
> > I've also got a patch deleting these confusing HMM_PFN_ERRORs. They
> > are not applied consistently and no caller would scan the output for
> > ERROR on some failures. For instance the above doesn't set it on EPERM.
> >
> > So this can just be 'return -EFAULT' instead of 'goto out_error'
> >
> > I can fold that in if you agree:
>
> If you want to fix this up and the other ->pfns initialization feel
> free. Otherwise I'd be happy to resend.
While we are at it: hmm_vma_walk_hole_ in the subject should be
hmm_vma_fault. I renamed the function on the last rebase as the old
name was so horrible.
next prev parent reply other threads:[~2020-03-16 18:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 13:53 misc hmm cleanups Christoph Hellwig
2020-03-16 13:53 ` [PATCH 1/5] mm: don't provide a stub for hmm_range_fault Christoph Hellwig
2020-03-16 14:37 ` Zi Yan
2020-03-16 16:45 ` Jason Gunthorpe
2020-03-16 13:53 ` [PATCH 2/5] mm: remove the unused HMM_FAULT_ALLOW_RETRY flag Christoph Hellwig
2020-03-16 16:44 ` Jason Gunthorpe
2020-03-16 13:53 ` [PATCH 3/5] mm: simplify hmm_vma_walk_hugetlb_entry Christoph Hellwig
2020-03-16 16:43 ` Jason Gunthorpe
2020-03-16 13:53 ` [PATCH 4/5] mm: don't handle the non-fault case in hmm_vma_walk_hole_ Christoph Hellwig
2020-03-16 16:43 ` Jason Gunthorpe
2020-03-16 13:53 ` [PATCH 5/5] mm: merge hmm_vma_do_fault into into hmm_vma_walk_hole_ Christoph Hellwig
2020-03-16 16:41 ` Jason Gunthorpe
2020-03-16 16:51 ` Christoph Hellwig
2020-03-16 18:01 ` Christoph Hellwig [this message]
2020-03-17 18:38 ` misc hmm cleanups Jason Gunthorpe
2020-03-17 18:55 ` Christoph Hellwig
2020-03-19 0:27 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200316180131.GA24031@lst.de \
--to=hch@lst.de \
--cc=jgg@ziepe.ca \
--cc=jglisse@redhat.com \
--cc=linux-mm@kvack.org \
--cc=rcampbell@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).