From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DA8DC0044D for ; Mon, 16 Mar 2020 19:49:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4C9C320679 for ; Mon, 16 Mar 2020 19:49:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="GGJyf40o" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C9C320679 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D3DED6B0003; Mon, 16 Mar 2020 15:49:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CEE306B0005; Mon, 16 Mar 2020 15:49:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BDC5B6B000A; Mon, 16 Mar 2020 15:49:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0003.hostedemail.com [216.40.44.3]) by kanga.kvack.org (Postfix) with ESMTP id A20536B0003 for ; Mon, 16 Mar 2020 15:49:22 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 3BCCE8248068 for ; Mon, 16 Mar 2020 19:49:22 +0000 (UTC) X-FDA: 76602264564.01.bulb06_178d94f35a348 X-HE-Tag: bulb06_178d94f35a348 X-Filterd-Recvd-Size: 4297 Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com [209.85.160.194]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Mon, 16 Mar 2020 19:49:21 +0000 (UTC) Received: by mail-qt1-f194.google.com with SMTP id d22so15399798qtn.0 for ; Mon, 16 Mar 2020 12:49:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=o7JqLPPCRpGtDbfSiR++DTgayckzFt0qLULy0U0IXIw=; b=GGJyf40oBvUn3UsnYOHO6ftCMOlhlUE53mKdQJAM3RZ49VrR7NfNu6vFSbIJg0Vrp+ nKaEHE/9u/3vvjCCe8WwHh8SthbR1oMP/lq3mlydxzkJGNn/tuTNACX8TZxQceM/9mon YIOCmCOQYTnLI6cUij9NQ1KEjPZ6YzkCBGaFSk2yslH5PGKF31RBGv+LalaZ8j2uIFLh bC7emlaCft8W3JdiciO0idkiwtVoNDBdFG9zx0aEVhvj80fXi5TE1dCzgDd5RWL/YOhG YYChBQ/vDVC92ft0WvWlgaDNuQmhJ1/CKwgNKV4aCfjmwGoqd/IKybrQhzqaZzus/5a5 BRgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=o7JqLPPCRpGtDbfSiR++DTgayckzFt0qLULy0U0IXIw=; b=feli9bcPzAtUAYEEA9fhYDmbgEndU+NmOkkeXCH2oK3pawoFIdNpwhamxHDSXBDX5N kixXOj4XAWVm8GyhQcRW1/EhksosR/bQfp1sNWHcrjhBKQM/cgV5quMExNwxs53IVh48 FUE9fMbfG2wv93KCHq/EBAZd4B+wPTULx6zm40Sk6Z6hq0pJOc280xWK2ow5sun7gcxI VhE09YOk5oKkk2eSgWSk/Trofe/sjt8a/A36EQGev/f8Cn0TD3OZgQI3QQgKpwYXWH5U yYEeGkRdw7mYj3jvq981qxvCz9zLDOdnSTrrPohBVlKTEywaUjO6rw0W8YtkoyAzhFKL sGrg== X-Gm-Message-State: ANhLgQ3Fy0qIbynfYI38fH8o2897+lCI9SXwYO2/c8m1YaFUFi1l7nTb q1CVac0OfhLHMPxVrXxOAAIkVg== X-Google-Smtp-Source: ADFU+vtYiqHgSFb/FCS3+UBgOOiW2jlaSoZd/0nI0+DDGOjwoiONzmkAwxqo+x9vqhMLJgCeBnROrw== X-Received: by 2002:ac8:5209:: with SMTP id r9mr1812897qtn.61.1584388161299; Mon, 16 Mar 2020 12:49:21 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id m67sm406383qke.101.2020.03.16.12.49.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 16 Mar 2020 12:49:20 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jDvjk-00071k-6b; Mon, 16 Mar 2020 16:49:20 -0300 Date: Mon, 16 Mar 2020 16:49:20 -0300 From: Jason Gunthorpe To: Christoph Hellwig Cc: Dan Williams , Bharata B Rao , Christian =?utf-8?B?S8O2bmln?= , Ben Skeggs , Jerome Glisse , kvm-ppc@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-mm@kvack.org Subject: Re: [PATCH 4/4] mm: check the device private page owner in hmm_range_fault Message-ID: <20200316194920.GA20010@ziepe.ca> References: <20200316193216.920734-1-hch@lst.de> <20200316193216.920734-5-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200316193216.920734-5-hch@lst.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 16, 2020 at 08:32:16PM +0100, Christoph Hellwig wrote: > Hmm range fault will succeed for any kind of device private memory, > even if it doesn't belong to the calling entity. While nouveau > has some crude checks for that, they are broken because they assume > nouveau is the only user of device private memory. Fix this by > passing in an expected pgmap owner in the hmm_range_fault structure. > > Signed-off-by: Christoph Hellwig > Fixes: 4ef589dc9b10 ("mm/hmm/devmem: device memory hotplug using ZONE_DEVICE") > --- > drivers/gpu/drm/nouveau/nouveau_dmem.c | 12 ------------ > include/linux/hmm.h | 2 ++ > mm/hmm.c | 10 +++++++++- > 3 files changed, 11 insertions(+), 13 deletions(-) Nice Reviewed-by: Jason Gunthorpe Jason