From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E14C8C0044D for ; Mon, 16 Mar 2020 21:33:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7EE1420679 for ; Mon, 16 Mar 2020 21:33:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7EE1420679 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CEE2E6B0003; Mon, 16 Mar 2020 17:33:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C9E846B0005; Mon, 16 Mar 2020 17:33:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BBC9F6B0007; Mon, 16 Mar 2020 17:33:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0085.hostedemail.com [216.40.44.85]) by kanga.kvack.org (Postfix) with ESMTP id A1AAF6B0003 for ; Mon, 16 Mar 2020 17:33:58 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 5DE2452CE for ; Mon, 16 Mar 2020 21:33:58 +0000 (UTC) X-FDA: 76602528156.23.lead57_3fb9e280b4e11 X-HE-Tag: lead57_3fb9e280b4e11 X-Filterd-Recvd-Size: 1718 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Mon, 16 Mar 2020 21:33:57 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id EF2A268CEC; Mon, 16 Mar 2020 22:33:53 +0100 (CET) Date: Mon, 16 Mar 2020 22:33:53 +0100 From: Christoph Hellwig To: Jason Gunthorpe Cc: Christoph Hellwig , Dan Williams , Bharata B Rao , Christian =?iso-8859-1?Q?K=F6nig?= , Ben Skeggs , Jerome Glisse , kvm-ppc@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-mm@kvack.org Subject: Re: [PATCH 3/4] mm: simplify device private page handling in hmm_range_fault Message-ID: <20200316213353.GA28441@lst.de> References: <20200316193216.920734-1-hch@lst.de> <20200316193216.920734-4-hch@lst.de> <20200316195923.GA26988@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200316195923.GA26988@ziepe.ca> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 16, 2020 at 04:59:23PM -0300, Jason Gunthorpe wrote: > However, between patch 3 and 4 doesn't this break amd gpu as it will > return device_private pages now if not requested? Squash the two? No change in behavior in this patch as long as HMM_PFN_DEVICE_PRIVATE isn't set in ->pfns or ->default_flags, which is the case for both nouveau and amdgpu. The existing behavior is broken for private pages not known to the driver, but that is fixed in the next patch.