From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3A6BC2BB1D for ; Tue, 17 Mar 2020 18:55:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5AE7D20724 for ; Tue, 17 Mar 2020 18:55:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5AE7D20724 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0CA1A6B0006; Tue, 17 Mar 2020 14:55:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 07A196B0007; Tue, 17 Mar 2020 14:55:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF9D36B0008; Tue, 17 Mar 2020 14:55:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0071.hostedemail.com [216.40.44.71]) by kanga.kvack.org (Postfix) with ESMTP id D989E6B0006 for ; Tue, 17 Mar 2020 14:55:41 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id A2DE2824556B for ; Tue, 17 Mar 2020 18:55:41 +0000 (UTC) X-FDA: 76605758082.25.jewel91_31a0f199ea92f X-HE-Tag: jewel91_31a0f199ea92f X-Filterd-Recvd-Size: 1940 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Tue, 17 Mar 2020 18:55:40 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 22FE368CFC; Tue, 17 Mar 2020 19:55:38 +0100 (CET) Date: Tue, 17 Mar 2020 19:55:37 +0100 From: Christoph Hellwig To: Jason Gunthorpe Cc: Christoph Hellwig , Jerome Glisse , Ralph Campbell , linux-mm@kvack.org Subject: Re: misc hmm cleanups Message-ID: <20200317185537.GA20962@lst.de> References: <20200316135310.899364-1-hch@lst.de> <20200317183823.GU20941@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200317183823.GU20941@ziepe.ca> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 17, 2020 at 03:38:23PM -0300, Jason Gunthorpe wrote: > On Mon, Mar 16, 2020 at 02:53:05PM +0100, Christoph Hellwig wrote: > > Hi Jason, > > > > I started looking at bits in my backlog that shouldn't get too much > > in your way. Here is a bunch of simple patches, on top of the series > > you sent out. > > I applied these two, I made the edits discussed to the last two > patches, and ran the series over the hmm tester Ralph has. > > Please take a quick check: > > https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/commit/?h=hmm&id=2a60cfb32b260468dc81dfc1f56fc0f9ebe9f2e5 > https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/commit/?h=hmm&id=ee37d9e6e47439fbd3a72b7c6a13b8ce216fb125 > > - Edited commit message to point out that the NONE set is a bug and > add fixes line. > - Drop the pfn error and update the commit message, remove now unused > pfn and i vars I wonder if just having those fixes as separate commits would have been more clear. But the updated patches do look correct to me.